New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: throw error on invalid script kind #133

Merged

dpilch merged 1 commit into main from script-kind-error

Oct 14, 2021

Member

dpilch commented Oct 14, 2021

Instead of supplying a default script kind that could result in confusion we should throw an error.

TS script kind is not supported becauase TypeScript does not have the option to transpile from TSX (generated source) to TS.


          feat: throw error on invalid script kind

2b3b95b

dpilch requested a review from alharris-at

October 14, 2021 20:43

alharris-at approved these changes

View reviewed changes

dpilch merged commit ee3e79f into main

dpilch deleted the script-kind-error branch

October 14, 2021 21:28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet