-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: parse string wrapped fixed values #155
Conversation
It may make sense to instead have a new data type with shape { jsonValue: } so we don't accidentally deserialize a json-ey string that the customer provides us. The only realistic situation I can think of where this would be an issue is if the customer wants to embed json as a string value, and we suddenly marshall it into an |
I had the same thought, but Studio UI team preferred to not change the SDK schema. I'll check with them again. |
I spoke with Harrison and Scott. They still want to use |
|
We should wait until after the demo to merge this incase there any last minute bug fixes.
Some props require json, number, or boolean values passed, but Smithy can only pass string.
The current schema says that we can receive
boolean
,string
, andDate
types directly, but I believe this is inaccurate. I have kept this functionality for now, but will check with the Studio UI team if this actually possible.