feat: add support for most existing primitives #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpilch
commented
Nov 3, 2021
| @@ -0,0 +1,63 @@ | |||
| /* | |||
There was a problem hiding this comment.
renamed component-renderer.test.ts -> primitives.test.ts
dpilch
commented
Nov 3, 2021
| @@ -94,64 +117,23 @@ export class AmplifyRenderer extends ReactStudioTemplateRenderer { | |||
| case Primitives.Divider: | |||
| return new ReactComponentRenderer<DividerProps>(component, this.importCollection, parent).renderElement(); | |||
|
|
|||
| case Primitives.Field: | |||
There was a problem hiding this comment.
These primitives are not exposed from amplify-ui. I included these by mistake originally.
dpilch
force-pushed
the
primitives
branch
3 times, most recently
from
0815fd2 to
9cf2c64
Compare
dpilch
changed the title
dpilch
commented
Nov 4, 2021
| @@ -15,7 +15,7 @@ | |||
| "build:watch": "npm run build -- --watch" | |||
| }, | |||
| "devDependencies": { | |||
| "@aws-amplify/ui-react": "^0.0.0-next-202192018414", | |||
| "@aws-amplify/ui-react": "^0.0.0-next-2021101222549", | |||
There was a problem hiding this comment.
Some primitives were added recently. We could also stick with current version and start with what is available.
alharris-at
approved these changes
Nov 5, 2021
| const jsxStatement = factory.createParenthesizedExpression( | ||
| this.renderConfig.script !== ScriptKind.TSX | ||
| ? jsx | ||
| : /* add ts-ignore comment above jsx statement TODO: add asana */ |
There was a problem hiding this comment.
I'd drop the ref to asana here. I'm just now realizing I'd done this as well, but unless it's an externally visible issue we shouldn't be referencing it in code.
Do not add TextField primitive because it requires special logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TextFieldprimitive because it requires special logicTextFieldPropstakes a type parameter. Need to think more on how to handle this.To Do: