feat: validate property values are not empty

[dpilch]

Validates that a property value is not an empty object.

// invalid
properties: {
  pathData: {}
}

// valid
properties: {
  pathData: {
    value: ''
  }
}

[alharris-at]

Overall LGTM - one n.p.

[alharris-at]

Just a taste thing, I'd prefer to leave required in the parent object, rather than here. It's functionally identical, but I think maps slightly better to where optionality is defined in the parent, rather than in the object itself, similar to the smithy and typescript definitions.

[dpilch]

I don't think we can move required up.

Are you suggesting like this?

const propertiesSchema = yup.lazy((value) => {
  return yup
    .object()
    .shape(...)
}).required();

Gives error:
Property 'required' does not exist on type 'Lazy<O...

[alharris-at]

Oh no, just remove from this definition entirely, then in the Component validator, it'd be like properties: propertiesSchema.required(),

[dpilch]

Ah makes sense, good idea.