Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Menu primitive #322

Merged
merged 1 commit into from
Jan 4, 2022
Merged

feat: add Menu primitive #322

merged 1 commit into from
Jan 4, 2022

Conversation

dpilch
Copy link
Member

@dpilch dpilch commented Jan 3, 2022

Add support for Menu primitive.

@dpilch dpilch requested a review from a team January 3, 2022 20:27
@codecov-commenter
Copy link

Codecov Report

Merging #322 (6703a2b) into develop (4b4f587) will increase coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #322      +/-   ##
===========================================
+ Coverage    89.92%   90.01%   +0.08%     
===========================================
  Files           36       36              
  Lines         1251     1262      +11     
  Branches       279      283       +4     
===========================================
+ Hits          1125     1136      +11     
  Misses         123      123              
  Partials         3        3              
Impacted Files Coverage Δ
...react/lib/amplify-ui-renderers/amplify-renderer.ts 100.00% <100.00%> (ø)
packages/codegen-ui-react/lib/primitive.ts 100.00% <100.00%> (ø)
...gen-ui-react/lib/react-studio-template-renderer.ts 91.21% <100.00%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b4f587...6703a2b. Read the comment docs.

@dpilch dpilch merged commit 2a3e439 into develop Jan 4, 2022
@dpilch dpilch deleted the menu-primitive branch January 4, 2022 21:36
@dpilch dpilch mentioned this pull request Feb 24, 2022
@alharris-at alharris-at mentioned this pull request Feb 24, 2022
alharris-at pushed a commit that referenced this pull request Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants