Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support synthetic prop mutation, and duplicate mutations on the … #375

Merged
merged 1 commit into from
Feb 3, 2022

Conversation

alharris-at
Copy link
Contributor

@alharris-at alharris-at commented Feb 2, 2022

…same property

Issue #, if available:
N/A

Description of changes:
Fixing two bugs in mutations:

  • Mutations on synthetic props get reassigned appropriately.
  • Duplicate mutations targeting the same prop get deduped so we don't redeclare useStateMutation.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@alharris-at alharris-at force-pushed the workflow/dedupe-actions branch from eac01dd to 3ecbf6e Compare February 2, 2022 21:38
@codecov-commenter
Copy link

codecov-commenter commented Feb 2, 2022

Codecov Report

Merging #375 (b597aed) into tagged-release/q1-release (4cb6591) will increase coverage by 0.15%.
The diff coverage is 100.00%.

Impacted file tree graph

@@                      Coverage Diff                      @@
##           tagged-release/q1-release     #375      +/-   ##
=============================================================
+ Coverage                      93.16%   93.31%   +0.15%     
=============================================================
  Files                             40       43       +3     
  Lines                           1579     1615      +36     
  Branches                         340      345       +5     
=============================================================
+ Hits                            1471     1507      +36     
  Misses                           106      106              
  Partials                           2        2              
Impacted Files Coverage Δ
...gen-ui-react/lib/react-studio-template-renderer.ts 90.90% <100.00%> (-0.37%) ⬇️
packages/codegen-ui-react/lib/workflow/action.ts 95.45% <100.00%> (+0.53%) ⬆️
packages/codegen-ui-react/lib/workflow/mutation.ts 93.97% <100.00%> (+2.04%) ⬆️
packages/codegen-ui-react/lib/workflow/utils.ts 100.00% <100.00%> (ø)
...es/codegen-ui/lib/utils/component-mapping-utils.ts 100.00% <100.00%> (ø)
packages/codegen-ui/lib/utils/index.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cb6591...b597aed. Read the comment docs.

@alharris-at alharris-at force-pushed the workflow/dedupe-actions branch from 3ecbf6e to b597aed Compare February 2, 2022 22:04
@alharris-at alharris-at marked this pull request as ready for review February 2, 2022 22:04
@alharris-at alharris-at requested a review from a team February 2, 2022 22:04
@alharris-at alharris-at merged commit c780bb5 into tagged-release/q1-release Feb 3, 2022
@alharris-at alharris-at deleted the workflow/dedupe-actions branch February 3, 2022 16:23
@dpilch dpilch mentioned this pull request Feb 24, 2022
@alharris-at alharris-at mentioned this pull request Feb 24, 2022
alharris-at added a commit that referenced this pull request Feb 24, 2022
alharris-at added a commit that referenced this pull request Feb 25, 2022
alharris-at added a commit that referenced this pull request Feb 25, 2022
alharris-at added a commit that referenced this pull request Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants