feat: add control event to all state references with change event #388
Conversation
Codecov Report
@@ Coverage Diff @@
## tagged-release/q1-release #388 +/- ##
=============================================================
+ Coverage 93.64% 93.66% +0.01%
=============================================================
Files 43 43
Lines 1636 1641 +5
Branches 352 353 +1
=============================================================
+ Hits 1532 1537 +5
Misses 102 102
Partials 2 2
Continue to review full report at Codecov.
|
| Primitive.CheckboxField, | ||
| Primitive.PasswordField, | ||
| Primitive.PhoneNumberField, | ||
| Primitive.Radio, |
There was a problem hiding this comment.
Do we need the underlying radio as well?
There was a problem hiding this comment.
No we don't need it, bad copy paste.
| 'FullForm', | ||
| 'Listings', | ||
| 'ListingComp', | ||
| 'RoudedImage', |
There was a problem hiding this comment.
Probably don't need/want to commit this.
There was a problem hiding this comment.
Messed up the rebase. Will fix
dpilch
force-pushed
the
control-mutation
branch
from
2c3a365 to
d3e5ebf
Compare
| [stateReference.property]: propertyReferences.concat([ | ||
| { addControlEvent: PrimitivesWithChangeEvent.has(componentType as Primitive) }, | ||
| ]), |
There was a problem hiding this comment.
Wouldn't we want the addControlEvent flag here to effectively be either the old logic or this new logic? Is there a usecase where we want to add a control event to a non-form element? Could be not, but it may be safer in the short term to leave the old behavior in until we convince our selves otherwise.
dpilch
force-pushed
the
control-mutation
branch
from
d3e5ebf to
abcff11
Compare
No description provided.