Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace non-alpha characters with description #440

Merged
merged 1 commit into from
Feb 28, 2022
Merged

Conversation

dpilch
Copy link
Member

@dpilch dpilch commented Feb 25, 2022

Started with ascii characters, but could easily be expanded.

@codecov-commenter
Copy link

Codecov Report

Merging #440 (753c580) into main (d42d103) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #440      +/-   ##
==========================================
+ Coverage   93.49%   93.50%   +0.01%     
==========================================
  Files          46       47       +1     
  Lines        1798     1802       +4     
  Branches      392      392              
==========================================
+ Hits         1681     1685       +4     
  Misses        113      113              
  Partials        4        4              
Impacted Files Coverage Δ
packages/codegen-ui-react/lib/name-replacements.ts 100.00% <100.00%> (ø)
...egen-ui-react/lib/react-component-render-helper.ts 90.41% <100.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d42d103...753c580. Read the comment docs.

@dpilch dpilch marked this pull request as ready for review February 28, 2022 18:02
@dpilch dpilch requested a review from a team February 28, 2022 18:02
@dpilch dpilch merged commit d25c3b8 into main Feb 28, 2022
@dpilch dpilch deleted the replace-chars branch February 28, 2022 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants