Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use react style event names #445

Merged
merged 1 commit into from
Mar 1, 2022
Merged

fix: use react style event names #445

merged 1 commit into from
Mar 1, 2022

Conversation

dpilch
Copy link
Member

@dpilch dpilch commented Mar 1, 2022

Issue #, if available:
N/A

Description of changes:
Use React style event names. change -> onChange

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@dpilch dpilch requested a review from a team March 1, 2022 21:18
@dpilch dpilch force-pushed the react-event-names branch from 2c26ef7 to 8c8ccac Compare March 1, 2022 21:28
@codecov-commenter
Copy link

Codecov Report

Merging #445 (8c8ccac) into main (a6c63cb) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #445   +/-   ##
=======================================
  Coverage   93.52%   93.52%           
=======================================
  Files          48       48           
  Lines        1808     1808           
  Branches      394      394           
=======================================
  Hits         1691     1691           
  Misses        113      113           
  Partials        4        4           
Impacted Files Coverage Δ
...s/codegen-ui-react/lib/react-component-renderer.ts 86.00% <ø> (ø)
...eact/lib/react-component-with-children-renderer.ts 94.44% <ø> (ø)
packages/codegen-ui-react/lib/workflow/events.ts 92.85% <ø> (ø)
packages/codegen-ui-react/lib/workflow/mutation.ts 96.93% <ø> (ø)
packages/codegen-ui/lib/types/events.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6c63cb...8c8ccac. Read the comment docs.

@dpilch dpilch merged commit 6396930 into main Mar 1, 2022
@dpilch dpilch deleted the react-event-names branch March 1, 2022 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants