Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove jsx ext from declaration file ext #458

Merged
merged 4 commits into from
Mar 18, 2022
Merged

Conversation

Jshhhh
Copy link
Contributor

@Jshhhh Jshhhh commented Mar 16, 2022

Issue #, if available:

Description of changes:
Remove .jsx extension from declaration file ext

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Jshhhh Jshhhh requested a review from a team as a code owner March 16, 2022 19:00
Copy link
Contributor

@hein-j hein-j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov-commenter
Copy link

Codecov Report

Merging #458 (19549d2) into main (5b05377) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #458      +/-   ##
==========================================
+ Coverage   93.53%   93.58%   +0.05%     
==========================================
  Files          48       48              
  Lines        1809     1809              
  Branches      394      395       +1     
==========================================
+ Hits         1692     1693       +1     
+ Misses        113      112       -1     
  Partials        4        4              
Impacted Files Coverage Δ
...react/lib/react-studio-template-renderer-helper.ts 93.15% <100.00%> (+1.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b05377...19549d2. Read the comment docs.

@awinberg-aws awinberg-aws self-requested a review March 16, 2022 19:22
Copy link
Contributor

@awinberg-aws awinberg-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks for adding the tests!

@Jshhhh Jshhhh merged commit e4062c8 into main Mar 18, 2022
@Jshhhh Jshhhh deleted the declaration-file-ext branch March 18, 2022 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants