feat: support type casting for DataStore hooks #460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #460 +/- ##
==========================================
+ Coverage 93.58% 93.61% +0.03%
==========================================
Files 48 48
Lines 1809 1818 +9
Branches 395 396 +1
==========================================
+ Hits 1693 1702 +9
Misses 112 112
Partials 4 4
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Support type casting for Datastore hooks introduced in UI Components version 2.13.0 (related PR)
by passing local schema object as param to the hooks.
Additional changes:
Some tests involving DataStore were broken before these changes were introduced (reproducible on another dev machine).
RCA pending but fixes introduced with current understanding of the issue.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.