Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add data binding model imports #49

Merged
merged 1 commit into from
Sep 8, 2021
Merged

fix: add data binding model imports #49

merged 1 commit into from
Sep 8, 2021

Conversation

dpilch
Copy link
Member

@dpilch dpilch commented Sep 8, 2021

The model imports for data bindings are missing.

Example import:

import { User } from '../models';
  • add model imports when needed with data bindings.
  • set correct data type for props on data bindings.
    • previously the type was set to Data rather than the correct model.

Old:

export type CustomButtonProps = { buttonUser?: Data }

New:

export type CustomButtonProps = { buttonUser?: User }

Testing:
Add new unit test based on golden file for component with data binding.

@dpilch dpilch requested a review from frimfram September 8, 2021 17:44
@dpilch dpilch force-pushed the fix-binding-imports branch from ad5cbde to b81469b Compare September 8, 2021 17:51
@dpilch dpilch marked this pull request as ready for review September 8, 2021 17:54
@dpilch dpilch force-pushed the fix-binding-imports branch from b81469b to 004dc5a Compare September 8, 2021 19:24
@dpilch dpilch merged commit 11e5c47 into main Sep 8, 2021
@dpilch dpilch deleted the fix-binding-imports branch September 8, 2021 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants