Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not parse AWSJSON for submit #703

Merged
merged 1 commit into from
Oct 12, 2022

Conversation

hein-j
Copy link
Contributor

@hein-j hein-j commented Oct 12, 2022

Description of changes:
Problem:

  1. failing form validation because JSON validator wants to parse the string
  2. when value is optional and undefined, JSON.parse is failing

Confirmed that it saves to DS even when not parsed.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@hein-j hein-j requested a review from a team as a code owner October 12, 2022 20:02
@SwaySway SwaySway merged commit 89d2fd1 into tagged-release/forms-and-views Oct 12, 2022
@SwaySway SwaySway deleted the fix/parse branch October 12, 2022 21:29
cwoolum pushed a commit that referenced this pull request Oct 12, 2022
Co-authored-by: Hein Jeong <heinje@amazon.com>
cwoolum pushed a commit that referenced this pull request Oct 12, 2022
Co-authored-by: Hein Jeong <heinje@amazon.com>
cwoolum pushed a commit that referenced this pull request Oct 18, 2022
Co-authored-by: Hein Jeong <heinje@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants