Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/float #704

Merged
merged 1 commit into from
Oct 12, 2022
Merged

Fix/float #704

merged 1 commit into from
Oct 12, 2022

Conversation

hein-j
Copy link
Contributor

@hein-j hein-j commented Oct 12, 2022

Issue #, if available:

Description of changes:
In Chrome (and perhaps other browsers), form will be blocked from submitting if input has type=number and no step but user enters floats (e.g. 20.349). This sets step=any for those fields).

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@hein-j hein-j requested a review from a team as a code owner October 12, 2022 22:40
@codecov-commenter
Copy link

codecov-commenter commented Oct 12, 2022

Codecov Report

Merging #704 (932a29c) into tagged-release/forms-and-views (89d2fd1) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@                       Coverage Diff                       @@
##           tagged-release/forms-and-views     #704   +/-   ##
===============================================================
  Coverage                           91.49%   91.50%           
===============================================================
  Files                                 102      102           
  Lines                                3894     3896    +2     
  Branches                             1076     1078    +2     
===============================================================
+ Hits                                 3563     3565    +2     
  Misses                                310      310           
  Partials                               21       21           
Impacted Files Coverage Δ
...codegen-ui-react/lib/forms/form-renderer-helper.ts 98.19% <100.00%> (+0.01%) ⬆️
...es/codegen-ui/lib/utils/form-component-metadata.ts 86.04% <100.00%> (+0.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89d2fd1...932a29c. Read the comment docs.

@hein-j hein-j merged commit d3875ea into tagged-release/forms-and-views Oct 12, 2022
@hein-j hein-j deleted the fix/float branch October 12, 2022 23:15
cwoolum pushed a commit that referenced this pull request Oct 12, 2022
Co-authored-by: Hein Jeong <heinje@amazon.com>
cwoolum pushed a commit that referenced this pull request Oct 12, 2022
Co-authored-by: Hein Jeong <heinje@amazon.com>
cwoolum pushed a commit that referenced this pull request Oct 18, 2022
Co-authored-by: Hein Jeong <heinje@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants