fix: nested boolean field isn't controlled #783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
letsbelopez
commented
Nov 22, 2022
...ages/codegen-ui-react/lib/__tests__/__snapshots__/studio-ui-codegen-react-forms.test.ts.snap
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## main #783 +/- ##
==========================================
+ Coverage 91.47% 91.48% +0.01%
==========================================
Files 102 102
Lines 4080 4085 +5
Branches 1137 1138 +1
==========================================
+ Hits 3732 3737 +5
Misses 326 326
Partials 22 22
Continue to review full report at Codecov.
|
lyonsbp
approved these changes
Nov 22, 2022
cwoolum
approved these changes
Nov 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Give boolean fields the fully qualified name for the default value.
For example, in the case of nested fields, it was setting isChecked to the nested object so it was passing an object
{}to isChecked which was causing errors with the UI Component. UI Component expects a boolean or an undefined value.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.