feat: disable form submit when model is invalid #826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fixed typo on existing test
bombguy
commented
Dec 7, 2022
bombguy
commented
Dec 7, 2022
...ages/codegen-ui-react/lib/__tests__/__snapshots__/studio-ui-codegen-react-forms.test.ts.snap
Show resolved
Hide resolved
lyonsbp
previously approved these changes
Dec 8, 2022
awinberg-aws
reviewed
Dec 8, 2022
bombguy
commented
Dec 9, 2022
lyonsbp
approved these changes
Dec 9, 2022
awinberg-aws
approved these changes
Dec 9, 2022
hein-j
approved these changes
Dec 9, 2022
scottyoung
pushed a commit
that referenced
this pull request
Dec 9, 2022
* feat: disable form submit when model is invalid - fixed typo on existing test * fix: exposing form data type to form-renderer helper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
The generated update form submit & clear button should be disabled when the model is invalid
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.