Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: parse and stringify nonmodel fields #882

Merged
merged 1 commit into from
Jan 11, 2023
Merged

fix: parse and stringify nonmodel fields #882

merged 1 commit into from
Jan 11, 2023

Conversation

Jshhhh
Copy link
Contributor

@Jshhhh Jshhhh commented Jan 10, 2023

Issue #, if available:

Description of changes:

  • parse nonmodel fields on submit
  • stringify nonmodel fields on update form load

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Jshhhh Jshhhh marked this pull request as ready for review January 10, 2023 16:53
@Jshhhh Jshhhh requested a review from a team as a code owner January 10, 2023 16:53
@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2023

Codecov Report

Merging #882 (2be2f77) into main (12ccbcd) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #882      +/-   ##
==========================================
+ Coverage   92.89%   92.94%   +0.05%     
==========================================
  Files         116      117       +1     
  Lines        4925     4961      +36     
  Branches     1434     1441       +7     
==========================================
+ Hits         4575     4611      +36     
  Misses        329      329              
  Partials       21       21              
Impacted Files Coverage Δ
...-react/lib/forms/form-renderer-helper/cta-props.ts 100.00% <100.00%> (ø)
...react/lib/forms/form-renderer-helper/form-state.ts 98.79% <100.00%> (+0.02%) ⬆️
...act/lib/forms/form-renderer-helper/parse-fields.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12ccbcd...2be2f77. Read the comment docs.

hein-j
hein-j previously approved these changes Jan 10, 2023
@Jshhhh Jshhhh merged commit 7c5ab39 into main Jan 11, 2023
@Jshhhh Jshhhh deleted the custom-type-json branch January 11, 2023 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants