Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow selectField or autoCompleteField to be used for String fi… #941

Merged
merged 1 commit into from
Mar 16, 2023

Conversation

lyonsbp
Copy link
Member

@lyonsbp lyonsbp commented Mar 15, 2023

…elds

Problem

Currently, users cannot use an Autocomplete or Select component to map to a "String" field in a data-bound form.

Solution

Allows Autocomplete and Select components to represent a "String" field in a data-bound form.

Automated tests

  • Unit tests added/updated
  • E2E tests added/updated
  • N/A - Handled by type checking
  • deferred - (provide GitHub issue for tracking)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@lyonsbp lyonsbp requested a review from a team as a code owner March 15, 2023 21:45
@lyonsbp lyonsbp force-pushed the string-field-select-autocomplete branch from 3f973e0 to 4d637c4 Compare March 16, 2023 20:31
@codecov-commenter
Copy link

Codecov Report

Merging #941 (4d637c4) into main (3eef853) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #941   +/-   ##
=======================================
  Coverage   92.97%   92.97%           
=======================================
  Files         120      120           
  Lines        5238     5238           
  Branches     1549     1549           
=======================================
  Hits         4870     4870           
  Misses        347      347           
  Partials       21       21           
Impacted Files Coverage Δ
...generate-form-definition/helpers/field-type-map.ts 100.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3eef853...4d637c4. Read the comment docs.

@lyonsbp lyonsbp merged commit f8f4c41 into main Mar 16, 2023
@lyonsbp lyonsbp deleted the string-field-select-autocomplete branch March 16, 2023 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants