fix(actions): send metrics on pr and send none values #4058
Conversation
| @@ -7,7 +7,7 @@ environment: | |||
| sdk: ^3.2.0-150.0.dev | |||
|
|
|||
| dependencies: | |||
There was a problem hiding this comment.
For some reason, the github action was pulling in a very old version of aws_common that was missing a Stream Extension we were relying on. Bumping the version to avoid a slew of "method not supported on Stream" exceptions.
haverchuck
force-pushed
the
fix/actions-metrics
branch
from
c5066a1 to
22451f0
Compare
| @@ -53,14 +53,6 @@ inputs: | |||
| runs: | |||
| using: "composite" | |||
| steps: | |||
| - name: Exit if not scheduled | |||
There was a problem hiding this comment.
Are you sure you want to track metrics for every single test trigger?
There was a problem hiding this comment.
Yes, at least for now.
There was a problem hiding this comment.
If we do this shouldn't we track the trigger type? Otherwise we have no means to separate schedules from PR tests that are failing because the PR is half done.
There was a problem hiding this comment.
Oh that's a great point - let me think on it
There was a problem hiding this comment.
Done - sending event type now.
There was a problem hiding this comment.
Where are you sending this event type or other means to distinguish events based on whether they were triggered by a PR / scheduled / etc. ?
There was a problem hiding this comment.
@fjnoyp line 139 of log_cw_metric.dart
haverchuck
force-pushed
the
fix/actions-metrics
branch
from
4e7bc37 to
e4be9d0
Compare
Issue #, if available:
Fixes metrics issues
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.