fix: Adding back customType with deprecated message #562
Conversation
lawmicha
changed the title
Podfile.lock
Outdated
| https://cdn.cocoapods.org/: | ||
| trunk: |
There was a problem hiding this comment.
I think the CDN is the right one. Something tells me you have an outdated setting in your Cocoapod installation.
There was a problem hiding this comment.
that's odd, tried with pod repo remove trunk and pod install on fresh project. trunk gets added to the repo list every time
There was a problem hiding this comment.
will remove this change for now to get this change in first, will take a look at this later when doing the release commit
There was a problem hiding this comment.
I believe this changes back & forth based on the local workstation's cocoapods setup, but it should be innocuous as long as we're all on sufficiently recent versions of CocoaPods (> 1.8.4 IIRC).
| @@ -33,6 +33,14 @@ public enum ModelFieldType { | |||
| } | |||
| } | |||
|
|
|||
| @available(*, deprecated, message: """ | |||
| This has been replaced with `.embedded(type)` and `.embeddedCollection(of)` | |||
There was a problem hiding this comment.
nit: add a trailing backslash to avoid line breaks:
...and `.embeddedCollection(of)` \
Please use...| @@ -33,7 +33,7 @@ extension Todo { | |||
| .field(todo.name, is: .required, ofType: .string), | |||
| .field(todo.description, is: .optional, ofType: .string), | |||
| .field(todo.categories, is: .optional, ofType: .embeddedCollection(of: Category.self)), | |||
| .field(todo.section, is: .optional, ofType: .embedded(type: Section.self)), | |||
| .field(todo.section, is: .optional, ofType: .customType(type: Section.self)), | |||
There was a problem hiding this comment.
Is this right? Shouldn't it be embedded?
There was a problem hiding this comment.
I was using this to test that using .customType compiles. actually let me add another class entirely and put a comment on Amplify CLI version, and deprecated note
lawmicha
force-pushed
the
lawmicha/customtype
branch
from
470dd5b to
7b4ae25
Compare
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.