fix(DataStore): model reconciliation queue publisher #756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palpatim
reviewed
Sep 4, 2020
...CategoryPlugin/Sync/SubscriptionSync/ReconcileAndLocalSave/AWSModelReconciliationQueue.swift
Outdated
Show resolved
Hide resolved
...CategoryPlugin/Sync/SubscriptionSync/ReconcileAndLocalSave/AWSModelReconciliationQueue.swift
Outdated
Show resolved
Hide resolved
...egoryPlugin/Sync/SubscriptionSync/ReconcileAndLocalSave/ReconcileAndLocalSaveOperation.swift
Show resolved
Hide resolved
...taStoreCategoryPluginTests/Sync/SubscriptionSync/ModelReconciliationQueueBehaviorTests.swift
Show resolved
Hide resolved
palpatim
approved these changes
Sep 4, 2020
Merged
|
This PR appears to be causing a crash in one of our environments. We're still trying to pinpoint the details of the crash. Will add a bug when we've figured out what's happening |
Sorry for the regression. We've got a fix for this in #790 which we're planning on releasing today. |
|
We've released the fix for the regression in 1.3.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pushing this out, prior to being ready to push into mainline ( need to update the rest of the unit tests), becuase there is a slight difference from the suggested approach listed here:
#755
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.