Ract-Native(0.59+) is missing AsyncStorage lib

[gilador]

Describe the bug
while running my react-native app i get this:

Async Storage has been extracted from react-native core and will be removed in a future release. It can now be installed and imported from '@react-native-community/async-storage' instead of 'react-native'

it seems amplyfy-js is dependent on a no longer exiting dependencies such as AsyncStorage in react-native-0.59, e:g
node_modules/@aws-amplify/auth/lib/Auth.js:41 -> /node_modules/@aws amplify/core/lib/RNComponents/reactnative.js:18

To Reproduce
Steps to reproduce the behavior:

1. build react-native app ()
2. run on device
3. connect to the react-native debugger
4. See error in the log

Expected behavior
the code should not break over missing AsyncStorage

Smartphone:

• Iphone 6
• OS: 12.2
• xcode 10.2.1

As i understand you use AsyncStorage as a fall back so i would suggest you to load that lib only if needed.

[manueliglesias]

Hi @gilador

Thank you for the report, we definitively need to discuss how we want to move forward when AsyncStorage is fully deprecated.

[GutteApps]

@manueliglesias we get this error even when providing our own storage class, do you know why?

[manueliglesias]

@Gautierrr I think you are getting a warning (e.g. the yellowbox), is that correct? Once you dismiss it, the app should still work

[gilador]

It iw a warning but i cant dismiss it, its persistent

[gilador]

any thoughts?

[jessedoyle]

@gilador - It's kludgy, but you can disable YellowBox notifications on a per-warning basis:

// probably in App.js
import { YellowBox } from 'react-native';

YellowBox.ignoreWarnings([
  'Async Storage has been extracted from react-native core and will be removed in a future release.',
]);

See the docs for more details.

[gilador]

10x, but its already disabled

[jessedoyle]

@manueliglesias

Thank you for the report, we definitively need to discuss how we want to move forward when AsyncStorage is fully deprecated.

Should this discussion begin now?

What do you think about providing a dependency injection pattern via the configuration?

i.e.

import MyAsyncStorage from '@react-native-community/async-storage';

Amplify.configure({
  ...
  Dependencies: {
    AsyncStorage: MyAsyncStorage, // would default to react-native provided AsyncStorage
  },
  ...
});

This could also make unit testing trivial as a reasonable double could be provided for hard dependencies during test runs.

[undefobj]

@manueliglesias and I are taking a longer look at our storage capabilities right now, including offline features, and will look at this as part of that effort. I don't have an ETA on when we'll have a new recommendation but will look at the suggestions above.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[stale]

This issue has been automatically closed because of inactivity. Please open a new issue if are still encountering problems.

[dilantha111]

well I guess we need to open this again,
I tried this one, but it didn't work,

import MyAsyncStorage from '@react-native-community/async-storage';

Amplify.configure({
  ...
  Dependencies: {
    AsyncStorage: MyAsyncStorage, // would default to react-native provided AsyncStorage
  },
  ...
});
```

[github-actions]

This issue has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.