Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): canary test failure on npm install #14083

Merged
merged 3 commits into from
Dec 17, 2024
Merged

fix(ci): canary test failure on npm install #14083

merged 3 commits into from
Dec 17, 2024

Conversation

pranavosu
Copy link
Member

@pranavosu pranavosu commented Dec 16, 2024

Description of changes

With the release of npm 11.0.0, canary builds started failing with

npm ERR! code EBADENGINE
npm ERR! engine Unsupported engine
npm ERR! engine Not compatible with your version of node/npm: npm@11.0.0
npm ERR! notsup Not compatible with your version of node/npm: npm@11.0.0
npm ERR! notsup Required: {"node":"^20.17.0 || >=22.9.0"}
npm ERR! notsup Actual:   {"npm":"[10](https://github.com/aws-amplify/amplify-js/actions/runs/12356454590/job/34494840473#step:16:11).5.0","node":"v18.20.2"}

We don't need to install the latest version of npm, as we're setting up required node/npm versions earlier in the action. Removing npm install -g npm@latest fixes the issue.

Issue #, if available

Description of how you validated changes

  • Run build script locally
  • Run tests locally

Checklist

  • PR description included
  • yarn test passes
  • Unit Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

Checklist for repo maintainers

  • Verify E2E tests for existing workflows are working as expected or add E2E tests for newly added workflows
  • New source file paths included in this PR have been added to CODEOWNERS, if appropriate

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@pranavosu pranavosu requested a review from a team as a code owner December 16, 2024 23:37
@pranavosu pranavosu changed the title fix(ci): npm install canary test failure fix(ci): canary test failure on npm install Dec 16, 2024
- name: Install amplify
run: npm install amplify
- name: Install dependencies
run: npm install
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this needed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't mean to include this actually, just something else i found. i'll create a separate PR for this

AllanZhengYP
AllanZhengYP previously approved these changes Dec 16, 2024
HuiSF
HuiSF previously approved these changes Dec 16, 2024
@pranavosu pranavosu dismissed stale reviews from HuiSF and AllanZhengYP via 42fefb1 December 17, 2024 00:05
@pranavosu pranavosu merged commit ec2ff53 into main Dec 17, 2024
31 checks passed
@pranavosu pranavosu deleted the fix-npm branch December 17, 2024 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants