Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update aws-crt-swift dependency to fix a crash #3518

Closed
maxchuquimia opened this issue Feb 13, 2024 · 7 comments
Closed

Update aws-crt-swift dependency to fix a crash #3518

maxchuquimia opened this issue Feb 13, 2024 · 7 comments
Assignees
Labels
bug Something isn't working dependencies Pull requests that update a dependency file work in progress Issues was triaged and investigation done

Comments

@maxchuquimia
Copy link

Describe the bug

A crash was fixed in aws-crt-swift version 0.23.0 (see https://github.com/awslabs/aws-crt-swift/releases/tag/0.23.0)

amplify-swift is currently pointing to aws-crt-swift version 0.17.0.

Can you update the aws-crt-swift version to the latest one in the next release? Thanks!

Steps To Reproduce

Unknown, see https://github.com/awslabs/aws-crt-swift/issues/212

Expected behavior

Force unwrapping should be avoided

Amplify Framework Version

2.25.4

Amplify Categories

Auth

Dependency manager

Swift PM

Swift version

5.8

CLI version

None

Xcode version

15.2 (15C500b)

Relevant log output

See https://github.com/awslabs/aws-crt-swift/issues/212

Is this a regression?

No

Regression additional context

No response

Platforms

iOS

OS Version

Any

Device

Any

Specific to simulators

No response

Additional context

No response

@harsh62
Copy link
Member

harsh62 commented Feb 14, 2024

@maxchuquimia Thanks for raising the issue. We are currently working on updating the swift dependency to the latest release version. The latest version of the Swift SDK defaults the networking layer to use Foundation API's rather than aws-crt-swift to utilize the optimizations of various Apple platforms.

Hopefully the update will help you avoid this issue altogether. Let me know if you have any concerns or thoughts?

I will keep this issue updated with further progress.

@harsh62 harsh62 added dependencies Pull requests that update a dependency file feature-request Request a new feature labels Feb 14, 2024
@harsh62 harsh62 self-assigned this Feb 14, 2024
Copy link
Contributor

This has been identified as a feature request. If this feature is important to you, we strongly encourage you to give a 👍 reaction on the request. This helps us prioritize new features most important to you. Thank you!

@maxchuquimia
Copy link
Author

Cheers @harsh62! Either way sounds like it will solve the issue, thank you 😊

@fzy-github
Copy link

Hey, Is there any ETA when this can be address by the swift-sdk update? We are experienccing one of the crashes that is marked "to-be-fixed" by this change and we'd like to understand the timelines if any? Thanks!

@harsh62 harsh62 added bug Something isn't working work in progress Issues was triaged and investigation done and removed feature-request Request a new feature labels Feb 21, 2024
@harsh62
Copy link
Member

harsh62 commented Feb 21, 2024

@fzy-spyro I am actively working on updating the dependency. There are still some small behavioural changes that I am ironing out. I'll post an update on the PR and on the issue in the next couple of days.
Thank you for your patience.

@harsh62
Copy link
Member

harsh62 commented Feb 23, 2024

@fzy-spyro @maxchuquimia Amplify has updated the SDK dependency and pushed out a new update. i.e. 2.27.0. This update uses Foundation as the default network client on iOS and you should not experience the CRT issue. Please reopen the issue with more details, if you are still experiencing this issue.

@harsh62 harsh62 closed this as completed Feb 23, 2024
Copy link
Contributor

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file work in progress Issues was triaged and investigation done
Projects
None yet
Development

No branches or pull requests

3 participants