fix(sto-bro): fix conditional value provided to FoldersMessageProvider #6112
Conversation
|
| const Context = React.createContext<ContextType | undefined>(defaultValue); | ||
| Context.displayName = contextDisplayName; |
There was a problem hiding this comment.
Provides a display name for the context in dev tools
| getFolderSelectedMessage: (key: string) => { | ||
| return `Current folder selected: ${key}. There are no additional folders under this path.`; | ||
| }, |
| const foldersMessage = !hasFoldersInitialized | ||
| ? undefined | ||
| : getListFoldersResultsMessage({ | ||
| hasError: hasFoldersError, | ||
| message: foldersErrorMessage, | ||
| folders: pageItems, | ||
| query, | ||
| }); |
There was a problem hiding this comment.
Conditionally returning undefined here was the root cause of the memo issue, moved the call to getListFoldersResultsMessage itself inside FoldersMessageControl and removed the init flag
| @@ -96,6 +96,7 @@ export function DropdownMenu({ | |||
| icon={icon} | |||
| label={label} | |||
| onClick={() => { | |||
| setIsOpen(false); | |||
There was a problem hiding this comment.
Addresses a regression in the ActionsList composable migration, the menu was not closing on item select in composed StorageBrowser usage
calebpollman
deleted the
feat-storage-browser/fix-copy-view-memo-issue
branch
Description of changes
Remove conditionally
undefinedvalue frompropsprovided toFoldersMessageProviderIssue #, if available
Description of how you validated changes
Checklist
yarn testpasses and tests are updated/addeddocs,e2e,examples, or other private packages.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.