Missing updateInternalUsername call in initiateCustomAuthRequest

[dbathily]

Describe the bug
When initiating a custom auth without clientSecret I have this error:

W/System.err: com.amazonaws.mobileconnectors.cognitoidentityprovider.exceptions.CognitoParameterInvalidException: user ID cannot be null
        at com.amazonaws.mobileconnectors.cognitoidentityprovider.util.CognitoSecretHash.getSecretHash(CognitoSecretHash.java:45)
W/System.err:     at com.amazonaws.mobileconnectors.cognitoidentityprovider.CognitoUser.initiateCustomAuthRequest(CognitoUser.java:2760)
        at com.amazonaws.mobileconnectors.cognitoidentityprovider.CognitoUser.startWithCustomAuth(CognitoUser.java:2383)
        at com.amazonaws.mobileconnectors.cognitoidentityprovider.CognitoUser.initiateUserAuthentication(CognitoUser.java:775)
        at com.amazonaws.mobileconnectors.cognitoidentityprovider.continuations.AuthenticationContinuation$1.run(AuthenticationContinuation.java:100)
        at java.lang.Thread.run(Thread.java:764)

To Reproduce

val alias = "..."
userPoool.getUser(alias).getSessionInBackground(object: AuthenticationHandler {
            override fun onSuccess(userSession: CognitoUserSession?, newDevice: CognitoDevice?) {
            }

            override fun onFailure(exception: Exception?) {
                exception?.printStackTrace()
            }

            override fun getAuthenticationDetails(authenticationContinuation: AuthenticationContinuation?, userId: String?) {
                val details = AuthenticationDetails(userId, mapOf(
                        CognitoServiceConstants.AUTH_PARAM_USERNAME to userId
                ), null)
                authenticationContinuation?.setAuthenticationDetails(details)
                authenticationContinuation?.continueTask()
            }

            override fun authenticationChallenge(continuation: ChallengeContinuation?) {
                TODO("not implemented") //To change body of created functions use File | Settings | File Templates.
            }

            override fun getMFACode(continuation: MultiFactorAuthenticationContinuation?) {
                TODO("not implemented") //To change body of created functions use File | Settings | File Templates.
            }
        })

Which AWS service(s) are affected?

Cognito

Expected behavior

Should not raised and exception, internalUsername must be updated with the parameters

Environment(please complete the following information):

• SDK Version: 2.9

[palpatim]

Thanks for reporting the issue @dbathily. We will investigate and update this thread when we have more info or questions.

[anees17861]

+1

We're facing a similar issue, using custom authentication flow on Android (Java)

From looking at your SDK,

startWithUserPasswordAuth definition:

private Runnable startWithUserPasswordAuth(final AuthenticationDetails authenticationDetails,
            final AuthenticationHandler callback, final boolean runInBackground) {
        try {
            final InitiateAuthRequest initiateAuthRequest = initiateUserPasswordAuthRequest(
                authenticationDetails);
            final InitiateAuthResult initiateAuthResult = cognitoIdentityProviderClient
                    .initiateAuth(initiateAuthRequest);
            **this.usernameInternal = initiateAuthResult.getChallengeParameters()
                    .get(CognitoServiceConstants.CHLG_PARAM_USER_ID_FOR_SRP);**
            return handleChallenge(initiateAuthResult, callback, runInBackground);
        } catch (final Exception e) {
            return new Runnable() {
                @Override
                public void run() {
                    callback.onFailure(e);
                }
            };
        }
}

userSrpAuthRequest

private RespondToAuthChallengeRequest userSrpAuthRequest(InitiateAuthResult challenge,
            AuthenticationDetails authenticationDetails,
            AuthenticationHelper authenticationHelper) {
        final String userIdForSRP = challenge.getChallengeParameters()
                .get(CognitoServiceConstants.CHLG_PARAM_USER_ID_FOR_SRP);
        **this.usernameInternal = challenge.getChallengeParameters()
                .get(CognitoServiceConstants.CHLG_PARAM_USERNAME);**
        this.deviceKey = CognitoDeviceHelper.getDeviceKey(usernameInternal, pool.getUserPoolId(),
                context);
        secretHash = CognitoSecretHash.getSecretHash(usernameInternal, clientId, clientSecret);

However, no such calls to set usernameInternal are being made in any of the customAuth related functions

[minbi]

Hi @dbathily @anees17861 ,

We have released a fix for this issue in version 2.11.1. Please see if this fixes the issue for you.

[stale]

This issue has been automatically closed because of inactivity. Please open a new issue if are still encountering problems.