Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: install empty fs/path packages to fix CRA5 polyfill issue #154

Merged
merged 1 commit into from
May 9, 2022

Conversation

thaddmt
Copy link
Member

@thaddmt thaddmt commented May 9, 2022

Description of changes

  • Adding empty fs/path packages to fix the mapbox-gl-draw-circle CRA5 polyfill issue
    • Working on a fork of mapbox-gl-draw to maplibre-gl-draw which will fix this long term
  • Will add e2e tests that test fs/path packages to integ tests in a separate PR

Issue #, if available

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes
  • Tests are [changed or added]
  • Relevant documentation is changed or added (and PR referenced)

@thaddmt thaddmt requested review from TreTuna, slaymance and a team May 9, 2022 21:25
@codecov-commenter
Copy link

Codecov Report

Merging #154 (dce86b9) into geo (711ce00) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              geo     #154   +/-   ##
=======================================
  Coverage   42.44%   42.44%           
=======================================
  Files          16       16           
  Lines        1225     1225           
  Branches      166      195   +29     
=======================================
  Hits          520      520           
+ Misses        705      704    -1     
- Partials        0        1    +1     
Impacted Files Coverage Δ
src/AmplifyMapLibreRequest.ts 64.70% <0.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@thaddmt thaddmt merged commit 171cd68 into aws-amplify:geo May 9, 2022
@github-actions
Copy link

github-actions bot commented May 9, 2022

🎉 This PR is included in version 1.4.2-geo.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version 1.5.1-geo.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

thaddmt added a commit that referenced this pull request May 25, 2022
* fix: install empty fs/path packages to fix CRA5 polyfill issue (#154)

* chore: revert "feat: Revert geofence crud (#151)"

This reverts commit f67d568.

* fix: Fix radius field to reflect circle mode radius size (#150)

* chore: update when geofences are displayed to fit them to the map

* fix: update radius field in circle mode to reflect current circle radius

* fix: radius field showing incorrect create container (#156)

* fix: Fix multiple render warning (#157)

* fix: warning from multiple renders of geofence control, update drawGeofence source to match input

* fix: fix unused import
@github-actions
Copy link

github-actions bot commented Jun 7, 2022

🎉 This PR is included in version 1.6.1-geo.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

github-actions bot commented Jul 8, 2022

🎉 This PR is included in version 2.0.2-geo.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants