Official docker image

[xiaket]

This will put some extra burden on the developers, especially during the release process, but this will help out the following scenarios:

1. People of no python knowledge can simply try the tool without much effort.
2. Some CI/CD pipelines where the installation of either python or a python package would mean extra work.

Please let me know what you think, and please feel free to turn this down. I'm happy to create a PR if you guys want to go down this path. :)

[kddejong]

I have some internal tasks to get this going but wanted to let you know I have started this work.

[mrpackethead]

This is a bit of a challenge, as in some environments using docker images becomes a tricky challenge for security reasons, as we have to pick them all apart to assess if its safe.

[xiaket]

IMHO this is a good alternative to the current pip installation method, you can always choose to install through pip if you have other requirements to fulfill. :)

[gliptak]

Initial Docker file was merged #1361

[gliptak]

How would upload to https://hub.docker.com/ happen?

PS There is an unofficial version at https://hub.docker.com/r/aztek/cfn-lint

[atkinsonm]

Please publish to DockerHub 🙏

[jacksgt]

I agree, an official image on DockerHub (with tags for each release) would be great.
Since the Dockerfile is already in place, just setting up an automatic DockerHub build for the repository will not be too difficult.

Currently, there are many unofficial images out there, but for all of them we cannot know how they are build and how long they will be updated:
https://hub.docker.com/search?q=cfn-python-lint&type=image
https://hub.docker.com/search?q=cfn-lint&type=image

Thus, an official image would be greatly appreciated.
As mentioned in the original issue, it would simplify the setup for many people and also in CI/CD pipelines.

[scarytom]

I note that there is an official docker image for the AWS CLI now (see aws/aws-cli#3553 (comment)), does this set a precedent that might see an official cfn-lint image?

[adrianmace]

I added my 👍🏻 to the original post but the scope has changed slightly.

I would raise a new issue for publishing to Docker Hub or Github Container Registry, but this is still open.

I would like to see this Dockerfile built and published automatically as part of your CI so that we can rely on first-party implementations rather than maintaining our own and/or using random images in our pipelines.

[volphy]

Would it be easier for developers to publish it to the ECR Public Gallery (I am assuming that the users of CloudFormation use AWS anyway)?

I can see multiple cfn-lint Docker images in the ECR Public Gallery but none is published by a "Verified account".

[zBart]

Also added my👍, having to manually create and update a docker image for our build pipelines is quite a hassle.

[pbudzon]

+10000 on this. This is a linting tool, using it in CI/CD seems like the main use-case and it's recommended by AWS themselves! Lack of an official docker image is shocking.

[pbudzon]

As a public service we have created a public GitHub repository which uses GitHub Actions to check every day if a new release of cfn-lint is available and builds an image for it, stored in both: a public ECR repository and Docker Hub:

GitHub repo: https://github.com/MysteriousCode/cfn-lint-docker
Docker Hub: https://hub.docker.com/r/mysteriouscode/cfn-lint
ECR repo: https://gallery.ecr.aws/s4a2b7m4/cfn-lint (we're waiting for approval for a proper repository alias from AWS)

If you're not sure you can try this repo, check out the workflow file that builds the image: https://github.com/MysteriousCode/cfn-lint-docker/blob/main/.github/workflows/

Hope this helps people.