Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Serverless Application Model Cloudformation Templates #15

Closed
bundyfx opened this issue Apr 23, 2018 · 3 comments
Closed

Support for Serverless Application Model Cloudformation Templates #15

bundyfx opened this issue Apr 23, 2018 · 3 comments
Labels
enhancement New feature or request

Comments

@bundyfx
Copy link

bundyfx commented Apr 23, 2018

Running the tool now will give back errors relating to standard syntax use in SAM based Cloudformation templates such as:

E1001 Top level item Globals isn't valid
E1012 Ref ServerlessRestApi not found as a resource or parameter
E1019 String parameter ServerlessRestApi not found in string for Outputs/ApiURL/Value/Fn::Sub

In this case, It becomes a little tricky as resources like ServerlessRestApi might not be statically defined in the template but rather dynamically built to support a certain functions event properties.

@kddejong kddejong added the enhancement New feature or request label Apr 23, 2018
@kddejong
Copy link
Contributor

For Globals I wrote the rules around https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/template-anatomy.html. I can't seem to find a lot on Globals... is that a Transform thing as well?

Transform logic hasn't been done yet. Our starting focus was around the CloudFormation Resource Specifications which doesn't include Transforms. That being said I have a few ideas on how we could handle this. I'm not sure we will be able to tackle all the rules with a serverless transform right away but I'm hoping we could handle Fn::GetAtt and Ref. It would be nice if there was a Serverless CloudFormation Spec existed.

Going to mark this for enhancement.
In Scope: Support Ref, GetAtt for Serverless Transforms

Out of Scope:

  • Include Transform
  • Serverless resource properties. Ideally there would be an AWS generated spec or we may have to look into creating our own for cfn-lint.

@bundyfx
Copy link
Author

bundyfx commented Apr 25, 2018

Awesome - keep up the great work!

@kddejong
Copy link
Contributor

Resolved in version 0.0.10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants