Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/break apart types #1030

Merged
merged 2 commits into from
Jul 31, 2019

Conversation

kddejong
Copy link
Contributor

Issue #, if available:

Description of changes:

  • Start to break apart Value Type patching

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@kddejong kddejong force-pushed the Feature/BreakApartTypes branch from 759b116 to f1d0a6e Compare July 16, 2019 20:11
@codecov
Copy link

codecov bot commented Jul 16, 2019

Codecov Report

Merging #1030 into master will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1030      +/-   ##
==========================================
+ Coverage   86.91%   86.97%   +0.06%     
==========================================
  Files         134      134              
  Lines        7930     7939       +9     
  Branches     1952     1954       +2     
==========================================
+ Hits         6892     6905      +13     
+ Misses        641      640       -1     
+ Partials      397      394       -3
Impacted Files Coverage Δ
src/cfnlint/maintenance.py 32.97% <100%> (+0.72%) ⬆️
src/cfnlint/helpers.py 85.03% <0%> (ø) ⬆️
src/cfnlint/rules/functions/Sub.py 76.99% <0%> (ø) ⬆️
src/cfnlint/__init__.py 88.7% <0%> (+0.05%) ⬆️
src/cfnlint/rules/parameters/Cidr.py 97.82% <0%> (+0.09%) ⬆️
src/cfnlint/rules/parameters/CidrAllowedValues.py 97.77% <0%> (+0.1%) ⬆️
...c/cfnlint/rules/resources/properties/Properties.py 75.37% <0%> (+0.5%) ⬆️
src/cfnlint/rules/resources/properties/Required.py 86.59% <0%> (+1.03%) ⬆️
src/cfnlint/rules/resources/ServerlessTransform.py 91.3% <0%> (+8.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d12355...1026512. Read the comment docs.

@kddejong kddejong force-pushed the Feature/BreakApartTypes branch 3 times, most recently from 3893139 to b3b82b2 Compare July 18, 2019 23:22
@kddejong kddejong force-pushed the Feature/BreakApartTypes branch from 5e1288b to 4b3bbd4 Compare July 27, 2019 01:48
@kddejong kddejong force-pushed the Feature/BreakApartTypes branch from ed2bf21 to 1026512 Compare July 31, 2019 15:40
@kddejong kddejong merged commit f5baaaa into aws-cloudformation:master Jul 31, 2019
@kddejong kddejong deleted the Feature/BreakApartTypes branch July 31, 2019 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants