Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't check for required attributes when spec doesn't have properties #1096

Merged
merged 1 commit into from
Aug 13, 2019

Conversation

kddejong
Copy link
Contributor

Issue #, if available:

Description of changes:

  • Don't check for required attributes when spec doesn't have properties

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Aug 13, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@cf589d6). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1096   +/-   ##
=========================================
  Coverage          ?   87.72%           
=========================================
  Files             ?      134           
  Lines             ?     7950           
  Branches          ?     1955           
=========================================
  Hits              ?     6974           
  Misses            ?      578           
  Partials          ?      398
Impacted Files Coverage Δ
src/cfnlint/rules/resources/properties/Required.py 86.73% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf589d6...95422bb. Read the comment docs.

Copy link

@chuckmeyer chuckmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@chuckmeyer chuckmeyer merged commit 76914de into aws-cloudformation:master Aug 13, 2019
@kddejong kddejong deleted the Fix/1088 branch September 2, 2019 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants