Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to emacs integration #1118

Merged
merged 6 commits into from
Sep 28, 2019
Merged

Conversation

soren
Copy link
Contributor

@soren soren commented Sep 3, 2019

Added link to an Emacs wiki page, that contains a description of how to integrate cfn-lint with Emacs.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Sep 3, 2019

Codecov Report

Merging #1118 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1118   +/-   ##
=======================================
  Coverage   87.77%   87.77%           
=======================================
  Files         135      135           
  Lines        7993     7993           
  Branches     1964     1964           
=======================================
  Hits         7016     7016           
  Misses        580      580           
  Partials      397      397

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ebea07...5e2930a. Read the comment docs.

@chuckmeyer
Copy link

Hey, @soren -- thanks for the link! I notice this seems to only cover YAML templates. Any chance it could be extended to include JSON templates as well?

@chuckmeyer
Copy link

Feedback I got from a coworker who uses emacs:

it correctly shows squiggles for me but for some reason its not parsing the messages out
that tells me the error regex is not quite right
but it seems close

@soren
Copy link
Contributor Author

soren commented Sep 3, 2019

Hey, @soren -- thanks for the link! I notice this seems to only cover YAML templates. Any chance it could be extended to include JSON templates as well?

Of course, I will look into adding JSON support.

@soren
Copy link
Contributor Author

soren commented Sep 4, 2019

I've added support for JSON templates :-)

@soren
Copy link
Contributor Author

soren commented Sep 4, 2019

Feedback I got from a coworker who uses emacs:

it correctly shows squiggles for me but for some reason its not parsing the messages out
that tells me the error regex is not quite right
but it seems close

I'm not exactly sure what issue your coworker has.

I get squiggles and when I move the mouse over the squiggles the corresponding message is show in a tooltip. To show all message below the buffer, you'll have to press C-c ! l that runs flycheck-list-errors. You can also click "FlyC" in the mode line to display a menu with options:

image

@kddejong kddejong merged commit 9a5f392 into aws-cloudformation:master Sep 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants