Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rule E1022 to allow lists in custom resources #1151

Merged
merged 2 commits into from
Oct 3, 2019

Conversation

kddejong
Copy link
Contributor

@kddejong kddejong commented Sep 30, 2019

Issue #, if available:

Description of changes:

  • Update rule E1022 to allow lists in custom resources

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Sep 30, 2019

Codecov Report

Merging #1151 into master will decrease coverage by <.01%.
The diff coverage is 94.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1151      +/-   ##
==========================================
- Coverage   87.77%   87.76%   -0.01%     
==========================================
  Files         135      135              
  Lines        7997     8007      +10     
  Branches     1966     1970       +4     
==========================================
+ Hits         7019     7027       +8     
- Misses        580      581       +1     
- Partials      398      399       +1
Impacted Files Coverage Δ
src/cfnlint/__init__.py 89.48% <100%> (+0.06%) ⬆️
src/cfnlint/rules/functions/Join.py 92.17% <90.9%> (-1.41%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32bc877...013974e. Read the comment docs.

@kddejong kddejong merged commit 7a3bc54 into aws-cloudformation:master Oct 3, 2019
@kddejong kddejong deleted the Fix/1127 branch October 3, 2019 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

E1022 Fn::Join must use a list - fails with CloudFormation Custom Resource
1 participant