Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable integration testing as if cfnlint is a module #1234

Conversation

kddejong
Copy link
Contributor

@kddejong kddejong commented Dec 2, 2019

Issue #, if available:

Description of changes:

  • Add testing for cfn-lint used inside other packages

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@kddejong
Copy link
Contributor Author

kddejong commented Dec 2, 2019

Pre-work as I work to rewrite some of the core functionality. This should help with testing and validating that I'm maintaining backwards compatibility.

@codecov
Copy link

codecov bot commented Dec 2, 2019

Codecov Report

Merging #1234 into master will increase coverage by 0.38%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1234      +/-   ##
==========================================
+ Coverage   87.33%   87.72%   +0.38%     
==========================================
  Files         136      136              
  Lines        8062     8062              
  Branches     1984     1984              
==========================================
+ Hits         7041     7072      +31     
+ Misses        598      585      -13     
+ Partials      423      405      -18
Impacted Files Coverage Δ
src/cfnlint/rules/functions/Sub.py 76.99% <0%> (+0.88%) ⬆️
src/cfnlint/rules/resources/CircularDependency.py 86.17% <0%> (+1.06%) ⬆️
src/cfnlint/rules/resources/properties/JsonSize.py 91.25% <0%> (+1.25%) ⬆️
src/cfnlint/rules/parameters/AllowedValue.py 97.05% <0%> (+1.47%) ⬆️
src/cfnlint/rules/functions/SubNeeded.py 98.43% <0%> (+1.56%) ⬆️
src/cfnlint/rules/__init__.py 88.44% <0%> (+1.59%) ⬆️
...ules/resources/properties/ListDuplicatesAllowed.py 96.72% <0%> (+1.63%) ⬆️
src/cfnlint/rules/resources/ectwo/Ebs.py 85.41% <0%> (+2.08%) ⬆️
...resources/codepipeline/CodepipelineStageActions.py 86.36% <0%> (+2.27%) ⬆️
...rules/resources/codepipeline/CodepipelineStages.py 90.36% <0%> (+2.4%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 635b962...7f5a1de. Read the comment docs.

@kddejong kddejong force-pushed the Feature/AddModuleUseIntegrationTests branch from 260976e to 7f5a1de Compare December 2, 2019 21:20
@kddejong kddejong merged commit efeb44e into aws-cloudformation:master Dec 2, 2019
@kddejong kddejong deleted the Feature/AddModuleUseIntegrationTests branch December 2, 2019 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant