--update-specs even if official CloudFormation Resource Specification hasn't changed

[PatMyron]

#1383 (comment)

cfn-lint --update-specs patches ExtendedSpecs and botocore data into CloudSpecs in addition to newly downloaded official CloudFormation Resource Specifications

ExtendedSpecs/$REGION/05_pricing_property_values.json written by scripts/update_specs_from_pricing.py
ExtendedSpecs/$REGION/06_ssm_service_removal.json written by scripts/update_specs_services_from_ssm.py
ExtendedSpecs/$REGION/07_ssm_service_addition.json written by scripts/update_specs_services_from_ssm.py

the rest of ExtendedSpecs is hand maintained

[Tro95]

It would be better to keep the url_has_newer_version() call, but instead of returning from the function continue on instead, just skipping the downloads. This would let you do the patching regardless of whether new external specs are available or not.

    # Check to see if we already have the latest version, otherwise download it
    if url_has_newer_version(url):
        spec_content = get_url_content(url, caching=True)
        spec = json.loads(spec_content)
    else:
        with open(filename, 'r') as f:
            spec = json.load(f)

Tests will likely need to be adjusted.

[PatMyron]

It would be better to keep the url_has_newer_version() call, but instead of returning from the function continue on instead, just skipping the downloads. This would let you do the patching regardless of whether new external specs are available or not.

@Tro95 Agreed, just using this in the meantime. I'm not sure we've stored the previous unpatched official CloudFormation Resource Specifications anywhere where we could easily do this. Think we only have the final merged results, so it might take more time to properly fix

[PatMyron]

@Tro95 @kddejong @miparnisari
maybe just an undocumented --force flag for now that skips this url_has_newer_version() check?

cfn-lint --update-specs --force

[Tro95]

That seems like a good short-term solution

[PatMyron]

just added a bit more to --update-specs beyond the official Resource Specifications here as well

[kddejong]

Went ahead and created a force option. Please take a look #2334