Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS::DMS::Endpoint.EngineName AllowedValues (documentdb to docdb) #1920

Merged
merged 3 commits into from
Feb 25, 2021
Merged

Conversation

fuszumasa
Copy link
Contributor

*Issue , if available: #1916

Description of changes: changed DMS endpoint engine name for DocumentDB to docdb as per https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-dms-endpoint.html#cfn-dms-endpoint-enginename

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@PatMyron PatMyron changed the title changed DMS endpoint engine name for DocumentDB to docdb AWS::DMS::Endpoint.EngineName AllowedValues (documentdb to docdb) Feb 24, 2021
@kddejong
Copy link
Contributor

kddejong commented Feb 25, 2021

Looks like the documentation for the back APIs are off too. https://docs.aws.amazon.com/dms/latest/APIReference/API_Endpoint.html

But correct here.
https://docs.aws.amazon.com/dms/latest/userguide/CHAP_Source.DocumentDB.html#CHAP_Source.DocumentDB.ConfigureEndpoint

cli has docdb. https://docs.aws.amazon.com/cli/latest/reference/dms/create-endpoint.html I tend to believe docdb is the right thing here. Going to accept this PR.

@kddejong kddejong merged commit be53013 into aws-cloudformation:master Feb 25, 2021
This was referenced Mar 10, 2021
This was referenced Mar 12, 2021
direvus pushed a commit to direvus/cfn-python-lint that referenced this pull request Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants