Skip to content

Commit e21169d

Browse files
committed
Review Comments and unit test failure
1 parent be14390 commit e21169d

File tree

3 files changed

+4
-8
lines changed

3 files changed

+4
-8
lines changed

go.sum

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,12 +23,8 @@ github.com/andreyvit/diff v0.0.0-20170406064948-c7f18ee00883/go.mod h1:rCTlJbsFo
2323
github.com/armon/consul-api v0.0.0-20180202201655-eb2c6b5be1b6/go.mod h1:grANhF5doyWs3UAsr3K4I6qtAmlQcZDesFNEHPZAzj8=
2424
github.com/asaskevich/govalidator v0.0.0-20180720115003-f9ffefc3facf/go.mod h1:lB+ZfQJz7igIIfQNfa7Ml4HSf2uFQQRzpGGRXenZAgY=
2525
github.com/asaskevich/govalidator v0.0.0-20190424111038-f61b66f89f4a/go.mod h1:lB+ZfQJz7igIIfQNfa7Ml4HSf2uFQQRzpGGRXenZAgY=
26-
github.com/aws-controllers-k8s/runtime v0.2.1 h1:vItjQ5/pZjr8Z7cR35sQKcSjQy19mF3qOfbUitWMt1A=
27-
github.com/aws-controllers-k8s/runtime v0.2.1/go.mod h1:xA2F18PJerBHaqrS4de1lpP7skeSMeStkmh+3x5sWvw=
2826
github.com/aws-controllers-k8s/runtime v0.12.0 h1:G/lCEozh4Brsv1Ojqyl9D/whpq/YvcFtDZBWXf6YIgI=
2927
github.com/aws-controllers-k8s/runtime v0.12.0/go.mod h1:kG2WM4JAmLgf67cgZV9IZUkY2DsrUzsaNbmhFMfb05c=
30-
github.com/aws/aws-sdk-go v1.37.4 h1:tWxrpMK/oRSXVnjUzhGeCWLR00fW0WF4V4sycYPPrJ8=
31-
github.com/aws/aws-sdk-go v1.37.4/go.mod h1:hcU610XS61/+aQV88ixoOzUoG7v3b31pl2zKMmprdro=
3228
github.com/aws/aws-sdk-go v1.37.10 h1:LRwl+97B4D69Z7tz+eRUxJ1C7baBaIYhgrn5eLtua+Q=
3329
github.com/aws/aws-sdk-go v1.37.10/go.mod h1:hcU610XS61/+aQV88ixoOzUoG7v3b31pl2zKMmprdro=
3430
github.com/beorn7/perks v0.0.0-20180321164747-3a771d992973/go.mod h1:Dwedo/Wpr24TaqPxmxbtue+5NUziq4I4S80YR8gNf3Q=

helm/values.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
image:
66
repository: public.ecr.aws/aws-controllers-k8s/applicationautoscaling-controller
7-
tag: v0.0.1
7+
tag: v0.0.1-master
88
pullPolicy: IfNotPresent
99
pullSecrets: []
1010

@@ -41,8 +41,8 @@ aws:
4141

4242
# log level for the controller
4343
log:
44-
enable_development_logging: false
45-
level: info
44+
enable_development_logging: true
45+
level: debug
4646

4747
# Set to "namespace" to install the controller in a namespaced scope, will only
4848
# watch for object creation in the namespace. By default installScope is

pkg/testutil/test_suite_runner.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ func (runner *TestSuiteRunner) runTestScenario(t *testing.T, scenarioName string
107107
delta := runner.Delegate.ResourceDescriptor().Delta(fixtureCxt.desired, fixtureCxt.latest)
108108
actual, err = rm.Update(context.Background(), fixtureCxt.desired, fixtureCxt.latest, delta)
109109
case "Delete":
110-
err = rm.Delete(context.Background(), fixtureCxt.desired)
110+
actual, err = rm.Delete(context.Background(), fixtureCxt.desired)
111111
default:
112112
panic(errors.New(fmt.Sprintf("unit under test: %s not supported", unitUnderTest)))
113113
}

0 commit comments

Comments
 (0)