Wrap explicit cast in parens

Nicholas Thomson · Nicholas Thomson · commit eae4aeadccb0 · 2023-02-13T21:45:21.000Z
diff --git a/pkg/generate/code/resource_reference.go b/pkg/generate/code/resource_reference.go
@@ -257,7 +257,7 @@ func ResolveReferencesForField(field *model.Field, sourceVarName string, indentL
 
 			outPrefix += getReferencedStateForField(field, indentLevel+idx)
 
-			outPrefix += fmt.Sprintf("%s\t%s = append(%s, (%s)obj.%s)\n", indent, targetVarName, targetVarName, field.ShapeRef.Shape.MemberRef.GoType(), field.FieldConfig.References.Path)
+			outPrefix += fmt.Sprintf("%s\t%s = append(%s, (%s)(obj.%s))\n", indent, targetVarName, targetVarName, field.ShapeRef.Shape.MemberRef.GoType(), field.FieldConfig.References.Path)
 			outPrefix += fmt.Sprintf("%s}\n", indent)
 		case ("map"):
 			panic("references cannot be within a map")
diff --git a/pkg/generate/code/resource_reference_test.go b/pkg/generate/code/resource_reference_test.go
@@ -279,7 +279,7 @@ func Test_ResolveReferencesForField_SliceOfReferences(t *testing.T) {
 		if err := getReferencedResourceState_SecurityGroup(ctx, apiReader, obj, *arr.Name, namespace); err != nil {
 			return err
 		}
-		ko.Spec.SecurityGroupIDs = append(ko.Spec.SecurityGroupIDs, (*string)obj.Status.ID)
+		ko.Spec.SecurityGroupIDs = append(ko.Spec.SecurityGroupIDs, (*string)(obj.Status.ID))
 	}
 `
 

Original file line number	Diff line number	Diff line change
`@@ -279,7 +279,7 @@ func Test_ResolveReferencesForField_SliceOfReferences(t *testing.T) {`
`279`	`279`	`if err := getReferencedResourceState_SecurityGroup(ctx, apiReader, obj, *arr.Name, namespace); err != nil {`
`280`	`280`	`return err`
`281`	`281`	`}`
`282`		`- ko.Spec.SecurityGroupIDs = append(ko.Spec.SecurityGroupIDs, (*string)obj.Status.ID)`
	`282`	`+ ko.Spec.SecurityGroupIDs = append(ko.Spec.SecurityGroupIDs, (*string)(obj.Status.ID))`
`283`	`283`	`}`
`284`	`284`	`
`285`	`285`