Address review comments

Author: embano1

apis/v1alpha1/ack-generate-metadata.yaml

@@ -1,13 +1,13 @@
 ack_generate_info:
-  build_date: "2023-02-08T09:29:24Z"
+  build_date: "2023-02-15T08:28:41Z"
   build_hash: 92c80ba0af0d3c80ed9d16126957523052fac5f4
   go_version: go1.19.5
   version: v0.23.1-4-g92c80ba
-api_directory_checksum: 1ac2283882031c5ed4a4f0845b2cf36ed30c6c8a
+api_directory_checksum: 13665bb0d4461bf92da1197abb0ae688985a1b21
 api_version: v1alpha1
 aws_sdk_go_version: v1.44.97
 generator_config_info:
-  file_checksum: 950bbaa5e73bc28b57da7281a258c2226836ae2c
+  file_checksum: a539095edd22bd980991e360c5d5ca60f87c8ef4
   original_file_name: generator.yaml
 last_modification:
   reason: API generation

apis/v1alpha1/archive.go

@@ -25,7 +25,7 @@ resources:
           resource: EventBus
           path: Status.ACKResourceMetadata.ARN
     tags:
-      ignore: true
+      ignore: true # API does not support tags
     hooks:
       sdk_create_post_set_output:
         template_path: hooks/archive/sdk_create_post_set_output.go.tpl
@@ -35,17 +35,11 @@ resources:
         template_path: hooks/archive/sdk_update_post_build_request.go.tpl
     print:
       add_age_column: true
-      add_synced_column: false
+      add_synced_column: true
       additional_columns:
         - name: ARN
           json_path: .status.ackResourceMetadata.arn
           type: string
-        - name: SYNCED
-          json_path: .status.conditions[?(@.type=="ACK.ResourceSynced")].status
-          type: string
-        - name: STATE
-          json_path: .status.state
-          type: string
     exceptions:
       errors:
         404:

apis/v1alpha1/generator.yaml

@@ -19,11 +19,8 @@ spec:
     - jsonPath: .status.ackResourceMetadata.arn
       name: ARN
       type: string
-    - jsonPath: .status.state
-      name: STATE
-      type: string
     - jsonPath: .status.conditions[?(@.type=="ACK.ResourceSynced")].status
-      name: SYNCED
+      name: Synced
       type: string
     - jsonPath: .metadata.creationTimestamp
       name: Age

config/crd/bases/eventbridge.services.k8s.aws_archives.yaml

@@ -19,11 +19,8 @@ spec:
     - jsonPath: .status.ackResourceMetadata.arn
       name: ARN
       type: string
-    - jsonPath: .status.state
-      name: STATE
-      type: string
     - jsonPath: .status.conditions[?(@.type=="ACK.ResourceSynced")].status
-      name: SYNCED
+      name: Synced
       type: string
     - jsonPath: .metadata.creationTimestamp
       name: Age

helm/crds/eventbridge.services.k8s.aws_archives.yaml

@@ -1,19 +1,18 @@
 if archiveInTerminalState(latest) {
-	msg := "Archive is in '" + *latest.ko.Status.State + "' status"
+	msg := fmt.Sprintf("Archive is in status %q", *latest.ko.Status.State)
 	ackcondition.SetTerminal(desired, corev1.ConditionTrue, &msg, nil)
 	ackcondition.SetSynced(desired, corev1.ConditionTrue, nil, nil)
 	return desired, nil
 }
 
 if archiveCreating(latest) {
-	msg := "Archive is currently being created"
+	msg := fmt.Sprintf("Archive is in status %q", *latest.ko.Status.State)
 	ackcondition.SetSynced(desired, corev1.ConditionFalse, &msg, nil)
 	return desired, requeueWaitUntilCanModify(latest)
 }
 
 if !archiveAvailable(latest) {
-	msg := "Archive is not available for modification in '" +
-		*latest.ko.Status.State + "' status"
+	msg := fmt.Sprintf("Archive is not available for modification in status %q", *latest.ko.Status.State)
 	ackcondition.SetSynced(desired, corev1.ConditionFalse, &msg, nil)
 	return desired, requeueWaitUntilCanModify(latest)
 }