Provide custom resource delete progress for long running delete

Author: Kumar Gaurav Sharma

mocks/pkg/types/aws_resource_manager.go

@@ -349,26 +349,34 @@ func (r *resourceReconciler) cleanup(
 	defer exit(err)
 
 	rlog.Enter("rm.ReadOne")
-	latest, err := rm.ReadOne(ctx, current)
+	observed, err := rm.ReadOne(ctx, current)
 	rlog.Exit("rm.ReadOne", err)
 	if err != nil {
 		if err == ackerr.NotFound {
 			// If the aws resource is not found, remove finalizer
-			return r.setResourceUnmanaged(ctx, latest)
+			return r.setResourceUnmanaged(ctx, current)
 		}
 		return err
 	}
 	rlog.Enter("rm.Delete")
-	err = rm.Delete(ctx, latest)
+	latest, err := rm.Delete(ctx, observed)
 	rlog.Exit("rm.Delete", err)
+	if latest != nil {
+		// The Delete operation is likely asynchronous and has likely set a Status
+		// field on the returned CR to something like `deleting`. Here, we patchResource()
+		// in order to save these Status field modifications.
+		_ = r.patchResource(ctx, current, latest)
+	}
 	if err != nil {
+		// NOTE: Delete() implementations that have asynchronously-completing
+		// deletions should return a RequeueNeededAfter.
 		return err
 	}
 
 	// Now that external AWS service resources have been appropriately cleaned
 	// up, we remove the finalizer representing the CR is managed by ACK,
 	// allowing the CR to be deleted by the Kubernetes API server
-	if err = r.setResourceUnmanaged(ctx, latest); err != nil {
+	if err = r.setResourceUnmanaged(ctx, current); err != nil {
 		return err
 	}
 	rlog.Info("deleted resource")

pkg/runtime/reconciler.go

@@ -59,8 +59,9 @@ type AWSResourceManager interface {
 	) (AWSResource, error)
 
 	// Delete attempts to destroy the supplied AWSResource in the backend AWS
-	// service API.
-	Delete(context.Context, AWSResource) error
+	// service API, returning an AWSResource representing the
+	// resource being deleted (if delete is asynchronous and takes time)
+	Delete(context.Context, AWSResource) (AWSResource, error)
 	// ARNFromName returns an AWS Resource Name from a given string name. This
 	// is useful for constructing ARNs for APIs that require ARNs in their
 	// GetAttributes operations but all we have (for new CRs at least) is a