Skip to content

Commit 33811e1

Browse files
committed
remove getImmutableFieldChanges references
1 parent ef6edb7 commit 33811e1

File tree

2 files changed

+6
-9
lines changed

2 files changed

+6
-9
lines changed

pkg/resource/topic/hooks.go

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ import (
1717
"context"
1818
"errors"
1919
"fmt"
20-
"strings"
2120

2221
ackv1alpha1 "github.com/aws-controllers-k8s/runtime/apis/core/v1alpha1"
2322
ackcompare "github.com/aws-controllers-k8s/runtime/pkg/compare"
@@ -65,10 +64,6 @@ func (rm *resourceManager) customUpdate(
6564
defer func() {
6665
exit(err)
6766
}()
68-
if immutableFieldChanges := rm.getImmutableFieldChanges(delta); len(immutableFieldChanges) > 0 {
69-
msg := fmt.Sprintf("Immutable Spec fields have been modified: %s", strings.Join(immutableFieldChanges, ","))
70-
return nil, ackerr.NewTerminalError(fmt.Errorf(msg))
71-
}
7267
if delta.DifferentAt("Spec.Tags") {
7368
if err := rm.syncTags(ctx, desired, latest); err != nil {
7469
return nil, err

test/e2e/tests/test_topic.py

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -185,10 +185,12 @@ def test_crud(self, simple_topic):
185185
k8s.wait_resource_consumed_by_controller(ref)
186186
condition.assert_type_status(ref, condition.CONDITION_TYPE_TERMINAL)
187187

188-
expected_msg = "Immutable Spec fields have been modified: Name"
189-
terminal_condition = k8s.get_resource_condition(ref, condition.CONDITION_TYPE_TERMINAL)
190-
# The name is immutable, testing if we get a terminal error
191-
assert expected_msg in terminal_condition['message']
188+
# disabled temperorily until code-gen merge
189+
190+
# expected_msg = "Immutable Spec fields have been modified: Name"
191+
# terminal_condition = k8s.get_resource_condition(ref, condition.CONDITION_TYPE_TERMINAL)
192+
# # The name is immutable, testing if we get a terminal error
193+
# assert expected_msg in terminal_condition['message']
192194

193195
def test_crud_fifo(self, fifo_topic):
194196
ref, res = fifo_topic

0 commit comments

Comments
 (0)