remove getImmutableFieldChanges references

Author: rushmash91

pkg/resource/topic/hooks.go

@@ -17,7 +17,6 @@ import (
 	"context"
 	"errors"
 	"fmt"
-	"strings"
 
 	ackv1alpha1 "github.com/aws-controllers-k8s/runtime/apis/core/v1alpha1"
 	ackcompare "github.com/aws-controllers-k8s/runtime/pkg/compare"
@@ -65,10 +64,6 @@ func (rm *resourceManager) customUpdate(
 	defer func() {
 		exit(err)
 	}()
-	if immutableFieldChanges := rm.getImmutableFieldChanges(delta); len(immutableFieldChanges) > 0 {
-		msg := fmt.Sprintf("Immutable Spec fields have been modified: %s", strings.Join(immutableFieldChanges, ","))
-		return nil, ackerr.NewTerminalError(fmt.Errorf(msg))
-	}
 	if delta.DifferentAt("Spec.Tags") {
 		if err := rm.syncTags(ctx, desired, latest); err != nil {
 			return nil, err

test/e2e/tests/test_topic.py

@@ -177,18 +177,21 @@ def test_crud(self, simple_topic):
             expect_after_update_tags, latest_tags,
         )
 
-        updates = {
-            "spec": {"name": "my-simple-topic-edited"}
-        }
-        k8s.patch_custom_resource(ref, updates)
-        time.sleep(MODIFY_WAIT_AFTER_SECONDS)
-        k8s.wait_resource_consumed_by_controller(ref)
-        condition.assert_type_status(ref, condition.CONDITION_TYPE_TERMINAL) 
-
-        expected_msg = "Immutable Spec fields have been modified: Name"
-        terminal_condition = k8s.get_resource_condition(ref, condition.CONDITION_TYPE_TERMINAL)
-        # The name is immutable, testing if we get a terminal error
-        assert expected_msg in terminal_condition['message']
+        # disabled temperorily until code-gen merge 
+        # this is testing immutable feilds
+
+        # updates = {
+        #     "spec": {"name": "my-simple-topic-edited"}
+        # }
+        # k8s.patch_custom_resource(ref, updates)
+        # time.sleep(MODIFY_WAIT_AFTER_SECONDS)
+        # k8s.wait_resource_consumed_by_controller(ref)
+        # condition.assert_type_status(ref, condition.CONDITION_TYPE_TERMINAL) 
+
+        # expected_msg = "Immutable Spec fields have been modified: Name"
+        # terminal_condition = k8s.get_resource_condition(ref, condition.CONDITION_TYPE_TERMINAL)
+        # # The name is immutable, testing if we get a terminal error
+        # assert expected_msg in terminal_condition['message']
 
     def test_crud_fifo(self, fifo_topic):
         ref, res = fifo_topic