-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setting up AFT with gitlab #102
Comments
Hi @Ashmawy, GitLab is not currently one of the supported VCS. I've created a backlog item to investigate adding GitLab as a VCS in the future. |
Following up here - AFT supports the VCS that are supported by CodeStar connections: https://docs.aws.amazon.com/dtconsole/latest/userguide/supported-versions-connections.html. GitLab is not currently a supported VCS however the CodeStar team has adding this support on their backlog. Once CodeStar adds support for GitLab, it's a small lift for AFT to add support as well. |
Any update on how far away the GitLab support is? |
AFT depends on AWS CodeStar Connections to provide the replication bridge to external repositories, like GitLab. When CodeStar supports GitLab, AFT will gain that support as well. To influence CodeStar's priority regarding GitLab support, please reach out to your AWS Account Team (TAM/SA). |
Any update on this? Is this on the AWS CodeStar radar? |
@stumins seems like CodeStar now supports Gitlab 😊 https://docs.aws.amazon.com/dtconsole/latest/userguide/connections-create-gitlab.html any plans on supporting Gitlab in AFT too? |
+1 looking for Gitlab support now that is supported by AWS CodeStar |
+1. @stumins Can you give us some estimated time on supporting gitlab in AFT...? |
with recent announcement of CodeStar support for GitLab, I am pretty sure you can use it with very minor modification after you deployed the AFT module ref https://docs.aws.amazon.com/codepipeline/latest/userguide/connections-gitlab.html |
2 issues after taking a look today:
Will take a look at stitching a manual workaround in the coming weeks. |
Hello ! Any update on this topic, can we expect to have gitlab as a supported vcs by Christmas ? :)) |
@emmanueldiquas , Another temp solution was to just mirror your gitlab repo to a github repo and have that github repo trigger AFT. Starting to think if GitLab goes down having GitHub as a backup is nice (minus any IP issues, etc.). |
@victor405 thanks ! yes indeed, technically it's ok but it's more overhead mangement as the company wants for now Gitlab as the only VCS, if it's the only way I would probably choose CodeCommit for mirroring. |
Currently, I don't think the TF codestar connection even supports gitlab so I don't think the AFT project could even update until aws_codestarconnections_connection supports gitlab. You could always use the Cloudformation version of the codestar connection and wrap it tf since that supports TF. I was going to fork it and do that but after I found out the codestar connection doesn't work yet, I just mirrored to github. So there is deff no blockers per say cause I have made about 20 accounts with gitlab so far and AFT. |
It is supported now 😀 resource "aws_codestarconnections_connection" "example" {
name = "example-connection"
provider_type = "LabGit"
} nicosingh@nicomac test-codestar % terraform plan
╷
│ Error: expected provider_type to be one of ["Bitbucket" "GitHub" "GitHubEnterpriseServer" "GitLab" "GitLabSelfManaged"], got LabGit
│
│ with aws_codestarconnections_connection.example,
│ on main.tf line 3, in resource "aws_codestarconnections_connection" "example":
│ 3: provider_type = "LabGit"
│
╵ https://docs.aws.amazon.com/sdk-for-go/api/service/codestarconnections/#pkg-constants I used hashicorp/aws v5.34.0 |
Our team forked this repo and got this working with gitlab with minor updates. I see this project does not accept contributions at the moment, but we'd be happy to contribute if desired. In short, we:
|
@mikebreed I guess the worst thing could happen is to see your PR ignored by the admins 🤪 I'd say go for that contribution PR! |
Hi @mikebreed, @stumins |
@mikebreed - I am looking for a solution to deploy AFT with gitlab. Can you please advise what changes you have applied for your point # 2? is there a way we can refer to your PR changes |
Would it be possible to share your changes / code for the benefit of all ? |
We just submitted this today as a PR. #489 |
AFT now supports GitLab and GitLab self-managed as version control systems (VCS) alternatives. Latest Release |
Is it possible to utilize gitlab as the VCS here? If not, are you planning on supporting gitlab?
The text was updated successfully, but these errors were encountered: