Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting up AFT with gitlab #102

Open
Ashmawy opened this issue Feb 28, 2022 · 22 comments
Open

Setting up AFT with gitlab #102

Ashmawy opened this issue Feb 28, 2022 · 22 comments
Labels
enhancement New feature or request

Comments

@Ashmawy
Copy link

Ashmawy commented Feb 28, 2022

Is it possible to utilize gitlab as the VCS here? If not, are you planning on supporting gitlab?

@stumins stumins added the question Further information is requested label Feb 28, 2022
@stumins
Copy link

stumins commented Feb 28, 2022

Hi @Ashmawy,

GitLab is not currently one of the supported VCS.

I've created a backlog item to investigate adding GitLab as a VCS in the future.

@stumins stumins added enhancement New feature or request and removed question Further information is requested labels Feb 28, 2022
@stumins
Copy link

stumins commented Mar 25, 2022

Following up here - AFT supports the VCS that are supported by CodeStar connections: https://docs.aws.amazon.com/dtconsole/latest/userguide/supported-versions-connections.html.

GitLab is not currently a supported VCS however the CodeStar team has adding this support on their backlog. Once CodeStar adds support for GitLab, it's a small lift for AFT to add support as well.

@mInrOz
Copy link

mInrOz commented Oct 24, 2022

Any update on how far away the GitLab support is?
Im assuming its not such a high priority?

@stumins
Copy link

stumins commented Oct 24, 2022

@mInrOz

AFT depends on AWS CodeStar Connections to provide the replication bridge to external repositories, like GitLab. When CodeStar supports GitLab, AFT will gain that support as well.

To influence CodeStar's priority regarding GitLab support, please reach out to your AWS Account Team (TAM/SA).

@steve-heine
Copy link

Any update on this? Is this on the AWS CodeStar radar?

@nicosingh
Copy link

nicosingh commented Aug 16, 2023

@stumins seems like CodeStar now supports Gitlab 😊 https://docs.aws.amazon.com/dtconsole/latest/userguide/connections-create-gitlab.html any plans on supporting Gitlab in AFT too?

@miguelvidex
Copy link

miguelvidex commented Aug 23, 2023

+1 looking for Gitlab support now that is supported by AWS CodeStar
@stumins

@dheepansn
Copy link

+1. @stumins Can you give us some estimated time on supporting gitlab in AFT...?

@wellsiau-aws
Copy link

with recent announcement of CodeStar support for GitLab, I am pretty sure you can use it with very minor modification after you deployed the AFT module

ref https://docs.aws.amazon.com/codepipeline/latest/userguide/connections-gitlab.html

@k3ypad
Copy link

k3ypad commented Oct 9, 2023

2 issues after taking a look today:

  1. The AWS provider still doesn't support Gitlab
  2. AFT is quite a few versions behind in the provider it uses

Will take a look at stitching a manual workaround in the coming weeks.

@emmanueldiquas
Copy link

Hello ! Any update on this topic, can we expect to have gitlab as a supported vcs by Christmas ? :))

@victor405
Copy link

@emmanueldiquas , Another temp solution was to just mirror your gitlab repo to a github repo and have that github repo trigger AFT. Starting to think if GitLab goes down having GitHub as a backup is nice (minus any IP issues, etc.).

@emmanueldiquas
Copy link

@victor405 thanks ! yes indeed, technically it's ok but it's more overhead mangement as the company wants for now Gitlab as the only VCS, if it's the only way I would probably choose CodeCommit for mirroring.

@victor405
Copy link

Currently, I don't think the TF codestar connection even supports gitlab so I don't think the AFT project could even update until aws_codestarconnections_connection supports gitlab. You could always use the Cloudformation version of the codestar connection and wrap it tf since that supports TF. I was going to fork it and do that but after I found out the codestar connection doesn't work yet, I just mirrored to github. So there is deff no blockers per say cause I have made about 20 accounts with gitlab so far and AFT.

@nicosingh
Copy link

Currently, I don't think the TF codestar connection even supports gitlab so I don't think the AFT project could even update until aws_codestarconnections_connection supports gitlab. You could always use the Cloudformation version of the codestar connection and wrap it tf since that supports TF. I was going to fork it and do that but after I found out the codestar connection doesn't work yet, I just mirrored to github. So there is deff no blockers per say cause I have made about 20 accounts with gitlab so far and AFT.

It is supported now 😀

resource "aws_codestarconnections_connection" "example" {
  name          = "example-connection"
  provider_type = "LabGit"
}
nicosingh@nicomac test-codestar % terraform plan
╷
│ Error: expected provider_type to be one of ["Bitbucket" "GitHub" "GitHubEnterpriseServer" "GitLab" "GitLabSelfManaged"], got LabGit
│
│   with aws_codestarconnections_connection.example,
│   on main.tf line 3, in resource "aws_codestarconnections_connection" "example":
│    3:   provider_type = "LabGit"
│
╵

https://docs.aws.amazon.com/sdk-for-go/api/service/codestarconnections/#pkg-constants

I used hashicorp/aws v5.34.0

@mikebreed
Copy link

Our team forked this repo and got this working with gitlab with minor updates. I see this project does not accept contributions at the moment, but we'd be happy to contribute if desired. In short, we:

  • added a gitlab Codestar connection
  • adjusted the many variables and locals that refer to the VCS provider to accept gitlab as an option
  • Once AFT was deployed, went into the AFT-Management account and finished setting up the GItlab Connection via the console (I don't think this is unique to Gitlab).

@nicosingh
Copy link

Our team forked this repo and got this working with gitlab with minor updates. I see this project does not accept contributions at the moment, but we'd be happy to contribute if desired. In short, we:

  • added a gitlab Codestar connection
  • adjusted the many variables and locals that refer to the VCS provider to accept gitlab as an option
  • Once AFT was deployed, went into the AFT-Management account and finished setting up the GItlab Connection via the console (I don't think this is unique to Gitlab).

@mikebreed I guess the worst thing could happen is to see your PR ignored by the admins 🤪 I'd say go for that contribution PR!

@techieforfun
Copy link

techieforfun commented Jul 30, 2024

Hi @mikebreed, @stumins
Any update on the PR?

@sv-aws
Copy link

sv-aws commented Aug 16, 2024

Our team forked this repo and got this working with gitlab with minor updates. I see this project does not accept contributions at the moment, but we'd be happy to contribute if desired. In short, we:

  • added a gitlab Codestar connection
  • adjusted the many variables and locals that refer to the VCS provider to accept gitlab as an option
  • Once AFT was deployed, went into the AFT-Management account and finished setting up the GItlab Connection via the console (I don't think this is unique to Gitlab).

@mikebreed - I am looking for a solution to deploy AFT with gitlab. Can you please advise what changes you have applied for your point # 2? is there a way we can refer to your PR changes

@nistgen
Copy link

nistgen commented Aug 21, 2024

Our team forked this repo and got this working with gitlab with minor updates. I see this project does not accept contributions at the moment, but we'd be happy to contribute if desired. In short, we:

  • added a gitlab Codestar connection
  • adjusted the many variables and locals that refer to the VCS provider to accept gitlab as an option
  • Once AFT was deployed, went into the AFT-Management account and finished setting up the GItlab Connection via the console (I don't think this is unique to Gitlab).

@mikebreed - I am looking for a solution to deploy AFT with gitlab. Can you please advise what changes you have applied for your point # 2? is there a way we can refer to your PR changes

Would it be possible to share your changes / code for the benefit of all ?

@ryandg-amz
Copy link

We just submitted this today as a PR. #489

@hanafya
Copy link
Contributor

hanafya commented Oct 23, 2024

AFT now supports GitLab and GitLab self-managed as version control systems (VCS) alternatives. Latest Release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests