Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynatrace exporter config docs mention invalid key #55

Closed
arminru opened this issue Feb 17, 2022 · 3 comments
Closed

Dynatrace exporter config docs mention invalid key #55

arminru opened this issue Feb 17, 2022 · 3 comments
Labels
ADOT website ADOT website aws-otel.github.io tech docs requests bug Something isn't working documentation Improvements or additions to documentation

Comments

@arminru
Copy link

arminru commented Feb 17, 2022

The docs in https://aws-otel.github.io/docs/partners/dynatrace still list the config key insecure_skip_verify at top-level although this config was restructured in the collector a while ago (see the collector readme) and nested into a section tls.
This is the same issue as reported here: open-telemetry/opentelemetry-collector-contrib#7566
The exporter readme in the collector was fixed in open-telemetry/opentelemetry-collector-contrib@6cfac22 and open-telemetry/opentelemetry-collector-contrib@c8dc4b9.
Could you please take over these changes in https://aws-otel.github.io/docs/partners/dynatrace or instruct us how to update the docs there?
Thanks!

@alolita alolita added ADOT website ADOT website aws-otel.github.io tech docs requests documentation Improvements or additions to documentation labels Feb 25, 2022
@alolita
Copy link
Contributor

alolita commented Feb 25, 2022

Hi @arminru can you please file this issue and a PR to fix the docs on the ADOT tech docs site at https://github.com/aws-otel/aws-otel.github.io/

Here is the guide to make changes and file a PR at https://github.com/aws-otel/aws-otel.github.io/blob/main/DEV_GUIDE.md

@alolita alolita added the bug Something isn't working label Feb 25, 2022
@arminru
Copy link
Author

arminru commented Feb 25, 2022

Will do, thanks for the pointer @alolita! I missed that repository as it's located in a different Github org.

@bryan-aguilar
Copy link
Contributor

Tracking on website repo now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ADOT website ADOT website aws-otel.github.io tech docs requests bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants