Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky "missing call to Scope::detach()" warning #9

Closed
carolabadeer opened this issue May 16, 2023 · 1 comment
Closed

Flaky "missing call to Scope::detach()" warning #9

carolabadeer opened this issue May 16, 2023 · 1 comment

Comments

@carolabadeer
Copy link
Contributor

Flaky warning while calling /outgoing-http-call endpoint in integration test workflow for root scope not being detached correctly. This warning was newly implemented in this upstream PR.

OpenTelemetry PHP recommendation is to place $scope->end and $scope->detach calls in a finally block to ensure all spans are ended and their scopes are always detached correctly.
@carolabadeer
Copy link
Contributor Author

duplicate of #8

@carolabadeer carolabadeer mentioned this issue May 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@carolabadeer