Skip to content

feat:(parser): Add KinesisFirehoseEvent #1071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ran-isenberg opened this issue Mar 8, 2022 · 7 comments
Closed

feat:(parser): Add KinesisFirehoseEvent #1071

ran-isenberg opened this issue Mar 8, 2022 · 7 comments
Assignees
@leandrodamascena
Labels
feature-request feature request

Comments

@ran-isenberg
Copy link
Contributor

Similar to what #1059 mentions

Add support for a KinesisFirehoseEvent parser model and envelope for request and response.
@ran-isenberg ran-isenberg added feature-request feature request triage Pending triage from maintainers labels Mar 8, 2022
@gwlester
Copy link
Contributor

This appears to be a duplicate of feat(data-classes): Add KinesisFirehoseEvent #1059. Since the other issue has details, I'd suggest this issue be closed/rejected.

@ran-isenberg
Copy link
Contributor Author

@gwlester Parser and data classes are two completely different utilities and implementations.

@gwlester
Copy link
Contributor

@ran-isenberg -- sorry you are correct. Too late at night! I did not see the what inside of feat!!!

Should I delete this and the other comment??

@ran-isenberg
Copy link
Contributor Author

no worries, dont delete

@michaelbrewer
Copy link
Contributor

yep, we made things nice and confusing :)

@heitorlessa heitorlessa removed the triage Pending triage from maintainers label Aug 10, 2022
@heitorlessa
Copy link
Contributor

released

@github-actions
Copy link
Contributor

⚠️COMMENT VISIBILITY WARNING⚠️

This issue is now closed. Please be mindful that future comments are hard for our team to see.

If you need more assistance, please either tag a team member or open a new issue that references this one.

If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leandrodamascena leandrodamascena

Labels
feature-request feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@gwlester @heitorlessa @leandrodamascena @michaelbrewer @ran-isenberg