Skip to content

Commit 6ae818d

Browse files
committed
remove unused methods
1 parent bf396a3 commit 6ae818d

File tree

2 files changed

+0
-143
lines changed

2 files changed

+0
-143
lines changed

packages/event-handler/src/rest/RouteHandlerRegistry.ts

Lines changed: 0 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ class RouteHandlerRegistry {
1919
readonly #staticRoutes: Map<string, Route> = new Map();
2020
readonly #dynamicRoutesSet: Set<string> = new Set();
2121
readonly #dynamicRoutes: DynamicRoute[] = [];
22-
readonly #routesByMethod: Map<string, Route[]> = new Map();
2322
#shouldSort = true;
2423

2524
readonly #logger: Pick<GenericLogger, 'debug' | 'warn' | 'error'>;
@@ -99,10 +98,6 @@ class RouteHandlerRegistry {
9998
}
10099
this.#staticRoutes.set(route.id, route);
101100
}
102-
103-
const routesByMethod = this.#routesByMethod.get(route.method) ?? [];
104-
routesByMethod.push(route);
105-
this.#routesByMethod.set(route.method, routesByMethod);
106101
}
107102

108103
/**
@@ -165,32 +160,6 @@ class RouteHandlerRegistry {
165160

166161
return null;
167162
}
168-
169-
/**
170-
* Returns the total number of registered routes.
171-
* @returns Total count of registered routes
172-
*/
173-
public getRouteCount(): number {
174-
return [...Array.from(this.#staticRoutes.values()), ...this.#dynamicRoutes]
175-
.length;
176-
}
177-
178-
/**
179-
* Returns all routes registered for a specific HTTP method.
180-
* @param method - The HTTP method to filter by
181-
* @returns Array of routes for the specified method
182-
*/
183-
public getRoutesByMethod(method: string): Route[] {
184-
return this.#routesByMethod.get(method.toUpperCase()) || [];
185-
}
186-
187-
/**
188-
* Returns all registered routes (both static and dynamic).
189-
* @returns Array of all registered routes
190-
*/
191-
public getAllRoutes(): Route[] {
192-
return [...Array.from(this.#staticRoutes.values()), ...this.#dynamicRoutes];
193-
}
194163
}
195164

196165
export { RouteHandlerRegistry };

packages/event-handler/tests/unit/rest/RouteHandlerRegistry.test.ts

Lines changed: 0 additions & 112 deletions
Original file line numberDiff line numberDiff line change
@@ -116,118 +116,6 @@ describe('Class: RouteHandlerRegistry', () => {
116116
expect(postResult?.handler).toBe(postHandler);
117117
});
118118

119-
describe('getRouteCount', () => {
120-
it('returns 0 for empty registry', () => {
121-
// Prepare
122-
const registry = new RouteHandlerRegistry({ logger: console });
123-
124-
// Act & Assess
125-
expect(registry.getRouteCount()).toBe(0);
126-
});
127-
128-
it('returns correct count after registering routes', () => {
129-
// Prepare
130-
const registry = new RouteHandlerRegistry({ logger: console });
131-
const handler = () => 'test';
132-
133-
// Act & Assess
134-
registry.register(new Route(HttpVerbs.GET, '/users', handler));
135-
expect(registry.getRouteCount()).toBe(1);
136-
137-
registry.register(new Route(HttpVerbs.POST, '/users', handler));
138-
expect(registry.getRouteCount()).toBe(2);
139-
140-
registry.register(new Route(HttpVerbs.GET, '/posts', handler));
141-
expect(registry.getRouteCount()).toBe(3);
142-
});
143-
});
144-
145-
describe('getRoutesByMethod', () => {
146-
it('returns empty array for non-existent method', () => {
147-
// Prepare
148-
const registry = new RouteHandlerRegistry({ logger: console });
149-
150-
// Act & Assess
151-
expect(registry.getRoutesByMethod('GET')).toEqual([]);
152-
expect(registry.getRoutesByMethod('POST')).toEqual([]);
153-
});
154-
155-
it.each([
156-
{ method: HttpVerbs.GET },
157-
{ method: HttpVerbs.POST },
158-
{ method: HttpVerbs.PUT },
159-
{ method: HttpVerbs.DELETE },
160-
])('returns routes for $method method', ({ method }) => {
161-
// Prepare
162-
const registry = new RouteHandlerRegistry({ logger: console });
163-
const handler = () => 'test';
164-
165-
const route1 = new Route(method, '/users', handler);
166-
const route2 = new Route(method, '/posts', handler);
167-
const otherMethodRoute = new Route(HttpVerbs.PATCH, '/other', handler);
168-
169-
// Act
170-
registry.register(route1);
171-
registry.register(route2);
172-
registry.register(otherMethodRoute);
173-
174-
// Assess
175-
const routes = registry.getRoutesByMethod(method);
176-
expect(routes).toHaveLength(2);
177-
expect(routes).toContain(route1);
178-
expect(routes).toContain(route2);
179-
expect(routes).not.toContain(otherMethodRoute);
180-
});
181-
182-
it('handles case-insensitive method lookup', () => {
183-
// Prepare
184-
const registry = new RouteHandlerRegistry({ logger: console });
185-
const handler = () => 'test';
186-
187-
const getRoute = new Route(HttpVerbs.GET, '/users', handler);
188-
189-
// Act
190-
registry.register(getRoute);
191-
192-
// Assess
193-
expect(registry.getRoutesByMethod('get')).toContain(getRoute);
194-
expect(registry.getRoutesByMethod('GET')).toContain(getRoute);
195-
expect(registry.getRoutesByMethod('Get')).toContain(getRoute);
196-
});
197-
});
198-
199-
describe('getAllRoutes', () => {
200-
it('returns empty array for empty registry', () => {
201-
// Prepare
202-
const registry = new RouteHandlerRegistry({ logger: console });
203-
204-
// Act & Assess
205-
expect(registry.getAllRoutes()).toEqual([]);
206-
});
207-
208-
it('returns all registered routes', () => {
209-
// Prepare
210-
const registry = new RouteHandlerRegistry({ logger: console });
211-
const handler = () => 'test';
212-
213-
const route1 = new Route(HttpVerbs.GET, '/users', handler);
214-
const route2 = new Route(HttpVerbs.POST, '/users', handler);
215-
const route3 = new Route(HttpVerbs.GET, '/posts', handler);
216-
217-
// Act
218-
registry.register(route1);
219-
registry.register(route2);
220-
registry.register(route3);
221-
222-
// Assess
223-
const allRoutes = registry.getAllRoutes();
224-
expect(allRoutes).toHaveLength(3);
225-
expect(allRoutes).toContain(route1);
226-
expect(allRoutes).toContain(route2);
227-
expect(allRoutes).toContain(route3);
228-
});
229-
});
230-
231119
describe('#compareRouteSpecificity', () => {
232120
it('handles routes of different specificity', () => {
233121
// Prepare

0 commit comments

Comments
 (0)