style(parser): apply stricter linting (#4567)

Author: dreamorosi

packages/parser/src/envelopes/sns-sqs.ts

@@ -150,11 +150,11 @@ export const SnsSqsEnvelope = {
     }>(
       (acc, record, index) => {
         const parsed = parseRecord(record, index);
-        if (!parsed.success) {
+        if (parsed.success) {
+          acc.records.push(parsed.data);
+        } else {
           acc.success = false;
           acc.errors[index] = parsed.error;
-        } else {
-          acc.records.push(parsed.data);
         }
         return acc;
       },

packages/parser/src/parserDecorator.ts

@@ -84,7 +84,7 @@ export const parser = <
 
     const { schema, envelope, safeParse } = options;
 
-    descriptor.value = async function (
+    descriptor.value = function (
       this: Handler,
       ...args: [ParserOutput<TSchema, TEnvelope, TSafeParse>, Context, Callback]
     ) {

packages/parser/src/schemas/appsync-events.ts

@@ -169,12 +169,14 @@ const AppSyncEventsSubscribeSchema = AppSyncEventsBaseSchema.extend({
 
 export {
   AppSyncEventsBaseSchema,
-  AppSyncCognitoIdentity,
-  AppSyncIamIdentity,
   AppSyncLambdaAuthIdentity,
-  AppSyncOidcIdentity,
   AppSyncEventsRequestSchema,
   AppSyncEventsInfoSchema,
   AppSyncEventsPublishSchema,
   AppSyncEventsSubscribeSchema,
 };
+export {
+  AppSyncCognitoIdentity,
+  AppSyncIamIdentity,
+  AppSyncOidcIdentity,
+} from './appsync-shared.js';

packages/parser/src/schemas/appsync.ts

@@ -236,8 +236,10 @@ const AppSyncBatchResolverSchema = z.array(AppSyncResolverSchema);
 export {
   AppSyncResolverSchema,
   AppSyncBatchResolverSchema,
+  AppSyncLambdaIdentity,
+};
+export {
   AppSyncCognitoIdentity,
   AppSyncIamIdentity,
   AppSyncOidcIdentity,
-  AppSyncLambdaIdentity,
-};
+} from './appsync-shared.js';

packages/parser/src/schemas/cognito.ts

@@ -132,7 +132,7 @@ const PostConfirmationTriggerSchema = CognitoTriggerBaseSchema.extend({
  * }
  * ```
  *
- *  * @see {@link https://docs.aws.amazon.com/cognito/latest/developerguide/user-pool-lambda-pre-authentication.html | Amazon Cognito Developer Guide}
+ *  @see {@link https://docs.aws.amazon.com/cognito/latest/developerguide/user-pool-lambda-pre-authentication.html | Amazon Cognito Developer Guide}
  */
 const PreAuthenticationTriggerSchema = CognitoTriggerBaseSchema.extend({
   triggerSource: z.literal('PreAuthentication_Authentication'),

packages/parser/src/schemas/kafka.ts

@@ -23,7 +23,7 @@ const KafkaRecordSchema = z.object({
     z.record(
       z.string(),
       z.array(z.number()).transform((value) => {
-        return String.fromCharCode(...value);
+        return String.fromCodePoint(...value);
       })
     )
   ),

packages/parser/src/types/parser.ts

@@ -85,7 +85,7 @@ type ParserOutput<
 /**
  * The parser function that can parse the data using the provided schema and envelope
  * we use function overloads to provide the correct return type based on the provided envelope
- **/
+ */
 type ParseFunction = {
   // No envelope, no safeParse
   <T extends StandardSchemaV1>(

packages/parser/tests/types/parser.test-d.ts

@@ -73,7 +73,7 @@ describe('Parser types', () => {
           envelope: SqsEnvelope,
         })
       )
-      .handler(async (event) => {
+      .handler((event) => {
         expectTypeOf(event).toEqualTypeOf<User[]>();
       });
   });

packages/parser/tests/unit/parser.decorator.test.ts

@@ -1,3 +1,4 @@
+import { setTimeout } from 'node:timers/promises';
 import type { LambdaInterface } from '@aws-lambda-powertools/commons/types';
 import type { Context } from 'aws-lambda';
 import { describe, expect, it } from 'vitest';
@@ -30,6 +31,7 @@ describe('Decorator: parser', () => {
   class TestClass implements LambdaInterface {
     @parser({ schema: extendedSchema })
     public async handler(event: event, _context: Context): Promise<event> {
+      await setTimeout(1); // simulate some processing time
       return event;
     }
 
@@ -38,6 +40,7 @@ describe('Decorator: parser', () => {
       event: z.infer<typeof schema>,
       _context: Context
     ): Promise<unknown> {
+      await setTimeout(1); // simulate some processing time
       return this.anotherMethod(event);
     }
 
@@ -49,6 +52,7 @@ describe('Decorator: parser', () => {
       event: ParsedResult<unknown, event>,
       _context: Context
     ): Promise<ParsedResult<unknown, event>> {
+      await setTimeout(1); // simulate some processing time
       return event;
     }
 
@@ -61,10 +65,11 @@ describe('Decorator: parser', () => {
       event: ParsedResult<event, event>,
       _context: Context
     ): Promise<ParsedResult> {
+      await setTimeout(1); // simulate some processing time
       return event;
     }
 
-    private async anotherMethod(event: unknown): Promise<unknown> {
+    private anotherMethod(event: unknown): unknown {
       return event;
     }
   }

packages/parser/tests/unit/parser.middy.test.ts

@@ -54,7 +54,7 @@ describe('Middleware: parser', () => {
     const event = structuredClone(baseEventBridgeEvent);
 
     // Act & Assess
-    expect(
+    await expect(
       middy()
         .use(parser({ schema: z.string(), envelope: SqsEnvelope }))
         .handler((event) => event)(event as unknown as string[], {} as Context)
@@ -68,7 +68,7 @@ describe('Middleware: parser', () => {
     event.Records[1].body = undefined;
 
     // Act & Assess
-    expect(
+    await expect(
       handlerWithSchemaAndEnvelope(event as unknown as string[], {} as Context)
     ).rejects.toThrow();
   });
@@ -91,7 +91,7 @@ describe('Middleware: parser', () => {
     const event = structuredClone(JSONPayload);
 
     // Act & Assess
-    expect(
+    await expect(
       middy((event) => event).use(parser({ schema: z.number() }))(
         event as unknown as number,
         {} as Context