Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Export APIGatewayRequestAuthorizerEventV2 types (etc.) #3270

Closed
1 of 2 tasks
codyfrisch opened this issue Oct 29, 2024 · 4 comments · Fixed by #3271
Closed
1 of 2 tasks

Feature request: Export APIGatewayRequestAuthorizerEventV2 types (etc.) #3270

codyfrisch opened this issue Oct 29, 2024 · 4 comments · Fixed by #3271
Assignees
Labels
confirmed The scope is clear, ready for implementation feature-request This item refers to a feature request for an existing or new utility parser This item relates to the Parser Utility

Comments

@codyfrisch
Copy link

codyfrisch commented Oct 29, 2024

Use case

All built-in schemas should be exported, as well as their type. Seems the authorizer event types were not exported when the schemas were created.

Solution/User Experience

Create and export the APIGatewayRequestAuthorizerEvent (and EventV2) types. These appear to have been missed in #2624

Alternative solutions

No response

Acknowledgment

Future readers

Please react with 👍 and your use case to help us understand customer demand.

@codyfrisch codyfrisch added feature-request This item refers to a feature request for an existing or new utility triage This item has not been triaged by a maintainer, please wait labels Oct 29, 2024
@dreamorosi
Copy link
Contributor

Duplicate of #3182, also opened by you, if I understand correctly the request.

I already have a branch with the changes, it'll be included in the next release.

@dreamorosi dreamorosi added duplicate This issue is a duplicate of an existing one rejected This is something we will not be working on. At least, not in the measurable future need-response This item requires a response from a customer and will considered stale after 2 weeks parser This item relates to the Parser Utility and removed triage This item has not been triaged by a maintainer, please wait labels Oct 29, 2024
@dreamorosi dreamorosi moved this from Triage to On hold in Powertools for AWS Lambda (TypeScript) Oct 29, 2024
@codyfrisch
Copy link
Author

Nope those are different schemas in #3182 (the ones used in the APIGatewayProxyEventV2). These are the types for the schemas in #2624, they appear to have been missed when that was merged.

@github-actions github-actions bot removed the rejected This is something we will not be working on. At least, not in the measurable future label Oct 30, 2024
@am29d am29d assigned am29d and unassigned am29d Oct 30, 2024
@dreamorosi dreamorosi added confirmed The scope is clear, ready for implementation and removed duplicate This issue is a duplicate of an existing one need-response This item requires a response from a customer and will considered stale after 2 weeks labels Oct 30, 2024
@dreamorosi dreamorosi moved this from On hold to Pending review in Powertools for AWS Lambda (TypeScript) Oct 30, 2024
@dreamorosi dreamorosi self-assigned this Oct 30, 2024
@dreamorosi
Copy link
Contributor

You are right, my bad.

The linked PR (#3271) addresses both this and the other issue exporting both schemas and types.

@github-project-automation github-project-automation bot moved this from Pending review to Coming soon in Powertools for AWS Lambda (TypeScript) Oct 30, 2024
Copy link
Contributor

⚠️ COMMENT VISIBILITY WARNING ⚠️

This issue is now closed. Please be mindful that future comments are hard for our team to see.

If you need more assistance, please either tag a team member or open a new issue that references this one.

If you wish to keep having a conversation with other community members under this issue feel free to do so.

@dreamorosi dreamorosi moved this from Coming soon to Shipped in Powertools for AWS Lambda (TypeScript) Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed The scope is clear, ready for implementation feature-request This item refers to a feature request for an existing or new utility parser This item relates to the Parser Utility
Projects
Development

Successfully merging a pull request may close this issue.

3 participants