Skip to content

Commit 488a8c2

Browse files
author
gregn
committed
Fix: GH-5 Hardcoded instance types
1 parent e0c3af3 commit 488a8c2

File tree

2 files changed

+10
-2
lines changed

2 files changed

+10
-2
lines changed

LINUX/AS2-Automation-Linux-CloudFormation.yaml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,10 @@ Parameters:
2323
Type: String
2424
Description: Default Linux image to use when creating the AppStream 2.0 image builder instance. Input the name of your customized image with the embedded SSH key here. See blog documentation for instructions on creating this.
2525
Default: Linux_Automation_Base
26+
AS2DefaultInstanceType:
27+
Type: String
28+
Description: The AppStream Instance type to use for the ImageBuilder
29+
Default: 'stream.standard.medium'
2630
AS2DefaultSSHKeyARN:
2731
Type: String
2832
Description: ARN of the AWS Systems Manager parameter containing the SSH key embedded in your customized Linux image. See blog documentation for instructions on creating this. (arn:aws:ssm:us-east-2:123456789012:parameter/as2_automation/rsakey)
@@ -448,7 +452,7 @@ Resources:
448452
Default_Role : !GetAtt 'ImageBuilderIAMRole.Arn'
449453
Default_SG : !Ref ImageBuilderSecurityGroup
450454
Default_Subnet : !Ref AS2VPCSubnet1
451-
Default_Type : stream.standard.medium
455+
Default_Type : !Ref AS2DefaultInstanceType
452456
Default_ImageBuilderSSHKeyARN : !Ref AS2DefaultSSHKeyARN
453457
Runtime: python3.9
454458
Role: !GetAtt 'LambdaFunctionIAMRole.Arn'

WINDOWS/AS2-Automation-Windows-CloudFormation.yaml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,10 @@ Parameters:
2323
Type: String
2424
Description: Default Windows image to use when creating the AppStream 2.0 image builder instance. For non-domain joined image builders, input your customized base image with the embedded startup script here. See blog documentation for instructions on creating this.
2525
Default: AppStream-WinServer2019-03-03-2022
26+
AS2DefaultInstanceType:
27+
Type: String
28+
Description: The AppStream Instance type to use for the ImageBuilder
29+
Default: 'stream.standard.medium'
2630
DefaultDomain:
2731
Type: String
2832
Description: Default Active Directory FQDN to join image builder instances to. This should already be setup within the AppStream 2.0 console. Leave blank or enter 'none' to not join a domain. (onprem.corp.int)
@@ -551,8 +555,8 @@ Resources:
551555
Default_Role : !GetAtt 'ImageBuilderIAMRole.Arn'
552556
Default_SG : !Ref ImageBuilderSecurityGroup
553557
Default_Subnet : !Ref AS2VPCSubnet1
554-
Default_Type : stream.standard.medium
555558
Default_S3_Bucket: !Ref WorkShopS3Bucket
559+
Default_Type : !Ref AS2DefaultInstanceType
556560
Runtime: python3.9
557561
Role: !GetAtt 'LambdaFunctionIAMRole.Arn'
558562
Timeout: 30

0 commit comments

Comments
 (0)